Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a unit #1020

Closed
huss opened this issue Sep 25, 2023 · 2 comments · Fixed by #1065
Closed

Delete a unit #1020

huss opened this issue Sep 25, 2023 · 2 comments · Fixed by #1065
Assignees

Comments

@huss
Copy link
Member

huss commented Sep 25, 2023

Is your feature request related to a problem? Please describe.

It would be good if a unit could be deleted as can be a conversion.

Describe the solution you'd like

If a unit is not used in a conversion, meter, or group then it should be safe to remove. This could be added to the edit unit modal page. We should check for any other conditions where it would be unsafe to delete a unit.

Describe alternatives you've considered

Currently states can be hidden so no one can use them which has a similar effect to deleting but does not remove them.

Additional context

As part of this effort, it would be good to remove suffix units created by OED if the suffix is illuminated. Currently, they are made hidden.

@sparakala21
Copy link
Contributor

Id like to work on this

@huss
Copy link
Member Author

huss commented Sep 27, 2023

First issue #901 should be done so IDs are not an issue but it may not be an issue since unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants