Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJP connector doesn't work #1533

Closed
cbeach47 opened this issue Mar 10, 2020 · 8 comments
Closed

AJP connector doesn't work #1533

cbeach47 opened this issue Mar 10, 2020 · 8 comments
Assignees
Milestone

Comments

@cbeach47
Copy link
Contributor

Describe the bug
In oEQ 2020.1.0, the AJP connector won't connect properly to web server requests.

To Reproduce
Steps to reproduce the behavior:

  1. Setup oEQ 2020.1.0 with AJP
  2. Setup Apache2 via AJP to oEQ's Tomcat
  3. Try to access oEQ via Apache2. Note error

Expected behavior
Apache should be able to service/forward requests onto Tomcat via AJP.

Platform:
Seen on:

  • OpenEquella Version: 2020.1.0
  • OS: CentOS & Ubuntu
@cbeach47 cbeach47 added this to the 2020.2 milestone Mar 10, 2020
@cbeach47
Copy link
Contributor Author

Looks like the issue was due to a mis-named configuration - requiredSecret was the old way to disable the ajp secret requirement, and should now be secretRequired.

Since I'm already in this area of the code, I'm confirming the ability to add ajp.secret to the connector.

@edalex-ian
Copy link
Member

Thanks @cbeach47 👍

@cathfitz
Copy link

@cbeach47 do you have a fix date in mind for this? - we have a couple of hotfixes awaiting this fix.

@cathfitz
Copy link

@cbeach47 any update on this fix?

@cbeach47
Copy link
Contributor Author

Sry for the delay @cathfitz - I'll get something out shortly.

@cbeach47
Copy link
Contributor Author

@cathfitz PR is now opened.

Test setup:
httpd oeq.conf:

<VirtualHost *:80>
	ServerName your-domain-or-ip
	ErrorLog /var/log/apache2/ajp.error.log
	CustomLog /var/log/apache2/ajp.log combined
	<Proxy *>
		AddDefaultCharset Off
		Order deny,allow
		Allow from all
	</Proxy>
ProxyPreserveHost On
    
	ProxyPass / ajp://127.0.0.1:8479/ nocanon
	ProxyPassReverse / ajp://127.0.0.1:8479/ nocanon
</VirtualHost>

oEQ mandatory-config.properties:

...
ajp.port = 8479
ajp.secret.required = false
...

@cbeach47
Copy link
Contributor Author

This has been tested, and I think it's good to be back-ported with a quick test in the patch releases.

As this gets closer to 2020.2.0 release, as well as hopefully Apache will support ajp secrets, doing another quick test would be good.

PenghaiZhang pushed a commit that referenced this issue Mar 31, 2020
* #1533 Added in ajp.secret and ajp.secret.required
PenghaiZhang pushed a commit that referenced this issue Mar 31, 2020
* #1533 Added in ajp.secret and ajp.secret.required
PenghaiZhang pushed a commit that referenced this issue Apr 1, 2020
* #1533 Added in ajp.secret and ajp.secret.required
@cathfitz
Copy link

cathfitz commented Apr 6, 2020

Tested and good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants