Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Convert to jsonrpc-derive, use jsonrpc-* from crates.io #10298

Merged
merged 8 commits into from
Feb 5, 2019

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Feb 5, 2019

Replaces jsonrpc-macros with jsonrpc-derive custom trait attribute. With the added bonus of now using published crates.

Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rpc/src/v1/traits/debug.rs Outdated Show resolved Hide resolved
@sorpaas sorpaas merged commit 89ae0f0 into master Feb 5, 2019
ordian added a commit that referenced this pull request Feb 5, 2019
* master:
  Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)
@niklasad1 niklasad1 deleted the aj-jsonrpc-derive branch February 5, 2019 15:01
@5chdn 5chdn added this to the 2.4 milestone Feb 7, 2019
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. M5-dependencies 🖇 Dependencies. labels Feb 7, 2019
ordian added a commit that referenced this pull request Apr 5, 2019
* master:
  fix: parity-clib/examples/cpp/CMakeLists.txt (#10313)
  CI optimizations (#10297)
  Increase number of requested block bodies in chain sync (#10247)
  Deprecate account management (#10213)
  Properly handle check_epoch_end_signal errors (#10015)
  fix(osx and windows builds): bump parity-daemonize (#10291)
  Add missing step for  Using `systemd` service file (#10175)
  Call private contract methods from another private contract (read-only)  (#10086)
  update ring to 0.14 (#10262)
  fix(secret-store): deprecation warning (#10301)
  Update to jsonrpc-derive 10.0.2, fixes aliases bug (#10300)
  Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M5-dependencies 🖇 Dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants