CI optimizations #10297

TriplEight · 2019-02-04T18:15:58Z

DONE:
new cache handler: sccache
npm(nodejs v10) and yarn for autodocs
test-all.sh - del lines checking changes in rust code
gitlab-ci - test-all.sh + nightly/beta removed, we won't need them
GIT_STRATEGY and GIT_SUBMODULE_STRATEGY - changed to fetch
this Dockerfile for testing only, will change the usual one as soon as it works

TODO:
update the initial container in CI
offer a piplene with cargo check for every commit, feedback into personal chat
sccache to work in Gcloud
https://vfoley.xyz/rust-compile-speed-tips/ LTO - can speed up

parity-cla-bot · 2019-02-04T18:16:01Z

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

parity-cla-bot · 2019-02-04T18:16:01Z

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

scripts/gitlab/test-all.sh

scripts/gitlab/build-unix.sh

test.sh

scripts/gitlab/test-all.sh

.gitlab-ci.yml

5chdn · 2019-02-08T13:27:36Z

snap misses libdb5.3, didn't we fix that already?

Failed to fetch stage packages: Error downloading packages for part 'parity': The package 'libdb' was not found..

https://gitlab.parity.io/parity/parity-ethereum/-/jobs/121253

AWS login failed

Unable to locate credentials. You can configure credentials by running "aws configure".

https://gitlab.parity.io/parity/parity-ethereum/-/jobs/121254

5chdn · 2019-02-08T13:27:55Z

.gitlab-ci.yml

@@ -2,11 +2,14 @@ stages:
  - test
  - build
  - publish
+  - publish-onchain


why is this an additional stage?

should depend on publishing to AWS.
This is not the final version of CI though.

.gitlab-ci.yml

5chdn · 2019-02-08T13:30:37Z

.gitlab-ci.yml

@@ -150,22 +203,3 @@ build-android:
  allow_failure:                   true
  <<:                              *collect_artifacts

-test-beta:
-  stage:                           optional


why did we remove this?

These two jobs were to test the code on stable Rust against beta and nightly Rust.
Developers answered they code only on stable Rust so it's not needed. What could be a bit more helpful is nightly build.

.gitlab-ci.yml

TriplEight · 2019-02-08T16:37:11Z

snap misses libdb5.3, didn't we fix that already?

Failed to fetch stage packages: Error downloading packages for part 'parity': The package 'libdb' was not found..

snap fix is not merged yet: https://github.com/paritytech/parity-ethereum/pull/10168/files

https://gitlab.parity.io/parity/parity-ethereum/-/jobs/121253

AWS login failed

fixed, in GitLab's env variables.

5chdn · 2019-02-11T13:26:58Z

This should not have been merged. I'm still on the fence with changes introduced here.

* CI optimizations * fix stripping * new dockerfile * no need n submodule upd * review * moved dockerfile * it becomes large * onchain update depends on s3 * fix dependency * fix cache status * fix cache status * new cache status

* version: bump stable to 2.2.10 * import rpc transactions sequentially (#10051) * import rpc transactions sequentially * use impl trait in argument position, renamed ProspectiveDispatcher to WithPostSign * grouped imports * integrates PostSign with ProspectiveSigner * fix spaces, removed unnecessary type cast and duplicate polling * clean up code style * Apply suggestions from code review * Additional tests for uint deserialization. (#10279) * Don't run the CPP example on CI (#10285) * Don't run the CPP example on CI * Add comment * CI optimizations (#10297) * CI optimizations * fix stripping * new dockerfile * no need n submodule upd * review * moved dockerfile * it becomes large * onchain update depends on s3 * fix dependency * fix cache status * fix cache status * new cache status * fix publish job (#10317) * fix publish job * dashes and colonels * Add Statetest support for Constantinople Fix (#10323) * Update Ethereum tests repo to v6.0.0-beta.3 tag * Add spec for St.Peter's / ConstantinopleFix statetests * fix(add helper for timestamp overflows) (#10330) * fix(add helper timestamp overflows) * fix(simplify code) * fix(make helper private) * fix(docker): fix not receives SIGINT (#10059) * fix(docker): fix not receives SIGINT * fix: update with reviews * update with review * update * update * snap: official image / test (#10168) * official image / test * fix / test * bit more necromancy * fix paths * add source bin/df /test * add source bin/df /test2 * something w paths /test * something w paths /test * add source-type /test * show paths /test * copy plugin /test * plugin -> nil * install rhash * no questions while installing rhash * publish snap only for release * Don't add discovery initiators to the node table (#10305) * Don't add discovery initiators to the node table * Use enums for tracking state of the nodes in discovery * Dont try to ping ourselves * Fix minor nits * Update timeouts when observing an outdated node * Extracted update_bucket_record from update_node * Fixed typo * Fix two final nits from @todr * change docker image based on debian instead of ubuntu due to the chan… (#10336) * change docker image based on debian instead of ubuntu due to the changes of the build container * role back docker build image and docker deploy image to ubuntu:xenial based (#10338) * perform stripping during build (#10208) * perform stripping during build (#10208) * perform stripping during build * var RUSTFLAGS * fix(docker-aarch64) : cross-compile config (#9798) * fix(docker-aarch64) : cross-compile config (#9798) * ci: remove trailing double newline from dockerfile

* version: bump beta to 2.3.3 * import rpc transactions sequentially (#10051) * import rpc transactions sequentially * use impl trait in argument position, renamed ProspectiveDispatcher to WithPostSign * grouped imports * integrates PostSign with ProspectiveSigner * fix spaces, removed unnecessary type cast and duplicate polling * clean up code style * Apply suggestions from code review * Fix Windows build (#10284) * Don't run the CPP example on CI (#10285) * Don't run the CPP example on CI * Add comment * CI optimizations (#10297) * CI optimizations * fix stripping * new dockerfile * no need n submodule upd * review * moved dockerfile * it becomes large * onchain update depends on s3 * fix dependency * fix cache status * fix cache status * new cache status * fix publish job (#10317) * fix publish job * dashes and colonels * Add Statetest support for Constantinople Fix (#10323) * Update Ethereum tests repo to v6.0.0-beta.3 tag * Add spec for St.Peter's / ConstantinopleFix statetests * Properly handle check_epoch_end_signal errors (#10015) * Make check_epoch_end_signal to only use immutable data * Move check_epoch_end_signals out of commit_block * Make check_epoch_end_signals possible to fail * Actually return the error from check_epoch_end_signals * Remove a clone * Fix import error * cargo: fix compilation * fix(add helper for timestamp overflows) (#10330) * fix(add helper timestamp overflows) * fix(simplify code) * fix(make helper private) * Remove CallContract and RegistryInfo re-exports from `ethcore/client` (#10205) * Remove re-export of `CallContract` and `RegistryInfo` from `ethcore/client` * Remove CallContract and RegistryInfo re-exports again This was missed while fixing merge conflicts * fix(docker): fix not receives SIGINT (#10059) * fix(docker): fix not receives SIGINT * fix: update with reviews * update with review * update * update * snap: official image / test (#10168) * official image / test * fix / test * bit more necromancy * fix paths * add source bin/df /test * add source bin/df /test2 * something w paths /test * something w paths /test * add source-type /test * show paths /test * copy plugin /test * plugin -> nil * install rhash * no questions while installing rhash * publish snap only for release * Don't add discovery initiators to the node table (#10305) * Don't add discovery initiators to the node table * Use enums for tracking state of the nodes in discovery * Dont try to ping ourselves * Fix minor nits * Update timeouts when observing an outdated node * Extracted update_bucket_record from update_node * Fixed typo * Fix two final nits from @todr * Extract CallContract and RegistryInfo traits into their own crate (#10178) * Create call-contract crate * Add license * First attempt at using extracted CallContract trait * Remove unneeded `extern crate` calls * Move RegistryInfo trait into call-contract crate * Move service-transaction-checker from ethcore to ethcore-miner * Update Cargo.lock file * Re-export call_contract * Merge CallContract and RegistryInfo imports * Remove commented code * Add documentation to call_contract crate * Add TODO for removal of re-exports * Update call-contract crate description Co-Authored-By: HCastano <HCastano@users.noreply.github.com> * Rename call-contract crate to ethcore-call-contract * Remove CallContract and RegistryInfo re-exports from `ethcore/client` (#10205) * Remove re-export of `CallContract` and `RegistryInfo` from `ethcore/client` * Remove CallContract and RegistryInfo re-exports again This was missed while fixing merge conflicts * fixed: types::transaction::SignedTransaction; (#10229) * fix daemonize dependency * fix build * change docker image based on debian instead of ubuntu due to the chan… (#10336) * change docker image based on debian instead of ubuntu due to the changes of the build container * role back docker build image and docker deploy image to ubuntu:xenial based (#10338) * perform stripping during build (#10208) * perform stripping during build (#10208) * perform stripping during build * var RUSTFLAGS

* master: fix: parity-clib/examples/cpp/CMakeLists.txt (#10313) CI optimizations (#10297) Increase number of requested block bodies in chain sync (#10247) Deprecate account management (#10213) Properly handle check_epoch_end_signal errors (#10015) fix(osx and windows builds): bump parity-daemonize (#10291) Add missing step for Using `systemd` service file (#10175) Call private contract methods from another private contract (read-only) (#10086) update ring to 0.14 (#10262) fix(secret-store): deprecation warning (#10301) Update to jsonrpc-derive 10.0.2, fixes aliases bug (#10300) Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)

CI optimizations

c572a7c

TriplEight added 2 commits February 4, 2019 19:34

fix stripping

543c254

new dockerfile

b1905b4

kirushik reviewed Feb 5, 2019

View reviewed changes

scripts/gitlab/test-all.sh Outdated Show resolved Hide resolved

no need n submodule upd

6ec2f2b

gabreal reviewed Feb 5, 2019

View reviewed changes

scripts/gitlab/build-unix.sh Outdated Show resolved Hide resolved

test.sh Show resolved Hide resolved

scripts/gitlab/test-all.sh Outdated Show resolved Hide resolved

.gitlab-ci.yml Outdated Show resolved Hide resolved

gabreal reviewed Feb 5, 2019

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

TriplEight added 2 commits February 5, 2019 17:25

review

dea8936

moved dockerfile

aeaa4a1

5chdn added this to the 2.4 milestone Feb 7, 2019

5chdn added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 7, 2019

TriplEight added 2 commits February 7, 2019 15:08

it becomes large

9b93870

onchain update depends on s3

0d68577

kirushik approved these changes Feb 7, 2019

View reviewed changes

TriplEight added 4 commits February 7, 2019 17:19

fix dependency

4073a3d

fix cache status

cb038d7

fix cache status

0bcd560

new cache status

e29476b

gabreal approved these changes Feb 7, 2019

View reviewed changes

TriplEight merged commit 83bcb81 into master Feb 7, 2019

5chdn deleted the dockerfile_update branch February 8, 2019 13:23

5chdn reviewed Feb 8, 2019

View reviewed changes

5chdn added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 11, 2019

5chdn mentioned this pull request Feb 12, 2019

Backports for Stable 2.2.10 #10332

Merged

14 tasks

5chdn mentioned this pull request Feb 12, 2019

Backports for Beta 2.3.3 #10333

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI optimizations #10297

CI optimizations #10297

TriplEight commented Feb 4, 2019

parity-cla-bot commented Feb 4, 2019

parity-cla-bot commented Feb 4, 2019

5chdn commented Feb 8, 2019

5chdn Feb 8, 2019

TriplEight Feb 8, 2019

5chdn Feb 8, 2019

TriplEight Feb 8, 2019

TriplEight commented Feb 8, 2019 •

edited

Loading

5chdn commented Feb 11, 2019

CI optimizations #10297

CI optimizations #10297

Conversation

TriplEight commented Feb 4, 2019

parity-cla-bot commented Feb 4, 2019

parity-cla-bot commented Feb 4, 2019

5chdn commented Feb 8, 2019

5chdn Feb 8, 2019

Choose a reason for hiding this comment

TriplEight Feb 8, 2019

Choose a reason for hiding this comment

5chdn Feb 8, 2019

Choose a reason for hiding this comment

TriplEight Feb 8, 2019

Choose a reason for hiding this comment

TriplEight commented Feb 8, 2019 • edited Loading

5chdn commented Feb 11, 2019

TriplEight commented Feb 8, 2019 •

edited

Loading