Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backports for Stable 2.2.10 #10332

Merged
merged 18 commits into from Feb 13, 2019
Merged

Backports for Stable 2.2.10 #10332

merged 18 commits into from Feb 13, 2019

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Feb 12, 2019

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. labels Feb 12, 2019
@5chdn 5chdn added this to the Patch milestone Feb 12, 2019
seunlanlege and others added 6 commits February 12, 2019 11:03
* import rpc transactions sequentially

* use impl trait in argument position, renamed ProspectiveDispatcher to WithPostSign

* grouped imports

* integrates PostSign with ProspectiveSigner

* fix spaces, removed unnecessary type cast and duplicate polling

* clean up code style

* Apply suggestions from code review
* Don't run the CPP example on CI

* Add comment
* CI optimizations

* fix stripping

* new dockerfile

* no need n submodule upd

* review

* moved dockerfile

* it becomes large

* onchain update depends on s3

* fix dependency

* fix cache status

* fix cache status

* new cache status
* fix publish job

* dashes and colonels
* Update Ethereum tests repo to v6.0.0-beta.3 tag

* Add spec for St.Peter's / ConstantinopleFix statetests
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 12, 2019
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in beta: #10330 would be good to get in too

@kirushik
Copy link
Collaborator

And #10305 please

niklasad1 and others added 4 commits February 12, 2019 15:40
* fix(add helper timestamp overflows)

* fix(simplify code)

* fix(make helper private)
* fix(docker): fix not receives SIGINT

* fix: update with reviews

* update with review

* update

* update
* official image / test

* fix / test

* bit more necromancy

* fix paths

* add source bin/df /test

* add source bin/df /test2

* something w paths /test

* something w paths /test

* add source-type /test

* show paths /test

* copy plugin /test

* plugin -> nil

* install rhash

* no questions while installing rhash

* publish snap only for release
* Don't add discovery initiators to the node table

* Use enums for tracking state of the nodes in discovery

* Dont try to ping ourselves

* Fix minor nits

* Update timeouts when observing an outdated node

* Extracted update_bucket_record from update_node

* Fixed typo

* Fix two final nits from @todr
@5chdn
Copy link
Contributor Author

5chdn commented Feb 12, 2019

Done

@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Feb 13, 2019
@5chdn 5chdn merged commit 7b1d3e1 into stable Feb 13, 2019
@5chdn 5chdn deleted the a5-stable-backports branch February 13, 2019 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants