This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[secretstore] migrate to version 4 #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
ordian
added
A3-inprogress ⏳
ordian
force-pushed
the
ao-migrate-secretstore-rocksdb-column
branch
from
7b5e01f
to
0a2e125
Compare
ordian
added
A0-pleasereview 🤓
dvdplm
approved these changes
Dec 10, 2019
| @@ -17,6 +17,7 @@ ethcore-accounts = { path = "../accounts", optional = true} | |||
| ethcore-call-contract = { path = "../ethcore/call-contract" } | |||
| ethcore-sync = { path = "../ethcore/sync" } | |||
| ethereum-types = "0.8.0" | |||
| ethkey = { path = "../accounts/ethkey", optional = true } | |||
There was a problem hiding this comment.
I had to add this too, to get parity-ethereum to build. A bit concerning CI didn't catch this.
|
Test failure looks legit. |
dvdplm
added
the
A7-looksgoodtestsfail 🤖
ordian
removed
the
A7-looksgoodtestsfail 🤖
niklasad1
reviewed
Dec 12, 2019
niklasad1
reviewed
Dec 12, 2019
Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>
ordian
added
A8-looksgood 🦄
dvdplm
pushed a commit
that referenced
this pull request
Dec 13, 2019
* secret-store: migrate the db to version 4 * Fix secretstore build * Fix secretstore build: include ethkey when building with the "accounts" feature * fix build * secret-store: actually use new column * a bunch of fixes * last nits * Apply suggestions from code review Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com> * secret-store: move db stuff to secret-store as per Anton's request
Merged
dvdplm
added a commit
that referenced
this pull request
Dec 15, 2019
…ate their data instead Merge branch 'master' into dp/chore/kvdb-no-default-column * master: tx-q: enable basic verification of local transactions (#11332) remove null signatures (#11335) ethcore/res: activate agharta on classic 9573000 (#11331) [secretstore] migrate to version 4 (#11322) Enable EIP-2384 for ice age hard fork (#11281) Fix atomicity violation in network-devp2p (#11277)
s3krit
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281) * ethcore/res: activate agharta on classic 9573000 (#11331) * Istanbul HF in xDai (2019-12-12) (#11299) * Istanbul HF in POA Core (2019-12-19) (#11298) * Istanbul HF in POA Sokol (2019-12-05) (#11282) * Activate ecip-1061 on kotti and mordor (#11338) * Enable basic verification of local transactions (#11332) * Disallow EIP-86 style null signatures for transactions outside tests (#11335) * SecretStore database migration to v4 (#11322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for paritytech/parity-common#278
I'm deliberately not using
util/migration-rocksdbhere in order to avoid adding more dependencies on parity-ethereum to secret-store as it's about to be moved.