This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
tx-q: enable basic verification of local transactions #11332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
ordian
commented
Dec 12, 2019
HCastano
reviewed
Dec 12, 2019
HCastano
reviewed
Dec 12, 2019
HCastano
reviewed
Dec 12, 2019
HCastano
reviewed
Dec 12, 2019
HCastano
approved these changes
Dec 12, 2019
Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com>
dvdplm
reviewed
Dec 12, 2019
ordian
added
the
B7-releasenotes 📜
dvdplm
approved these changes
Dec 13, 2019
|
@tomusdrw can you give this a once-over as well please? :) |
tomusdrw
approved these changes
Dec 13, 2019
* master: remove null signatures (#11335)
ordian
added
A8-looksgood 🦄
dvdplm
pushed a commit
that referenced
this pull request
Dec 13, 2019
* tx-q: basic verification of local transactions * miner: basic test for local import * miner: info log when rejecting local txn * Hernandofmt Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com> * miner: assert in a test with the concrete error type * tx-q: info! -> warn! on local tx rejection
dvdplm
pushed a commit
that referenced
this pull request
Dec 13, 2019
* tx-q: basic verification of local transactions * miner: basic test for local import * miner: info log when rejecting local txn * Hernandofmt Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com> * miner: assert in a test with the concrete error type * tx-q: info! -> warn! on local tx rejection
dvdplm
added a commit
that referenced
this pull request
Dec 15, 2019
…ate their data instead Merge branch 'master' into dp/chore/kvdb-no-default-column * master: tx-q: enable basic verification of local transactions (#11332) remove null signatures (#11335) ethcore/res: activate agharta on classic 9573000 (#11331) [secretstore] migrate to version 4 (#11322) Enable EIP-2384 for ice age hard fork (#11281) Fix atomicity violation in network-devp2p (#11277)
s3krit
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281) * ethcore/res: activate agharta on classic 9573000 (#11331) * Istanbul HF in xDai (2019-12-12) (#11299) * Istanbul HF in POA Core (2019-12-19) (#11298) * Istanbul HF in POA Sokol (2019-12-05) (#11282) * Activate ecip-1061 on kotti and mordor (#11338) * Enable basic verification of local transactions (#11332) * Disallow EIP-86 style null signatures for transactions outside tests (#11335)
s3krit
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281) * ethcore/res: activate agharta on classic 9573000 (#11331) * Istanbul HF in xDai (2019-12-12) (#11299) * Istanbul HF in POA Core (2019-12-19) (#11298) * Istanbul HF in POA Sokol (2019-12-05) (#11282) * Activate ecip-1061 on kotti and mordor (#11338) * Enable basic verification of local transactions (#11332) * Disallow EIP-86 style null signatures for transactions outside tests (#11335) * SecretStore database migration to v4 (#11322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't measured the perf impact yet.