Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

tx-q: enable basic verification of local transactions #11332

Merged
merged 8 commits into from
Dec 13, 2019

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Dec 12, 2019

I haven't measured the perf impact yet.

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M4-core ⛓ Core client code / Rust. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Dec 12, 2019
@ordian ordian added this to the 2.7 milestone Dec 12, 2019
miner/src/pool/client.rs Show resolved Hide resolved
miner/src/pool/verifier.rs Outdated Show resolved Hide resolved
ordian and others added 2 commits December 12, 2019 22:39
Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com>
ethcore/src/miner/miner.rs Outdated Show resolved Hide resolved
miner/src/pool/client.rs Show resolved Hide resolved
miner/src/pool/verifier.rs Outdated Show resolved Hide resolved
@ordian ordian added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Dec 13, 2019
@ordian ordian requested a review from dvdplm December 13, 2019 14:23
@dvdplm
Copy link
Collaborator

dvdplm commented Dec 13, 2019

@tomusdrw can you give this a once-over as well please? :)

* master:
  ethcore/res: activate agharta on classic 9573000 (#11331)
  [secretstore] migrate to version 4 (#11322)
  Enable EIP-2384 for ice age hard fork (#11281)
@ordian ordian merged commit fd29926 into master Dec 13, 2019
@ordian ordian deleted the ao-verify-basic-local-txns branch December 13, 2019 19:25
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 13, 2019
dvdplm pushed a commit that referenced this pull request Dec 13, 2019
* tx-q: basic verification of local transactions

* miner: basic test for local import

* miner: info log when rejecting local txn

* Hernandofmt

Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com>

* miner: assert in a test with the concrete error type

* tx-q: info! -> warn! on local tx rejection
dvdplm pushed a commit that referenced this pull request Dec 13, 2019
* tx-q: basic verification of local transactions

* miner: basic test for local import

* miner: info log when rejecting local txn

* Hernandofmt

Co-Authored-By: Hernando Castano <HCastano@users.noreply.github.com>

* miner: assert in a test with the concrete error type

* tx-q: info! -> warn! on local tx rejection
This was referenced Dec 14, 2019
dvdplm added a commit that referenced this pull request Dec 15, 2019
…ate their data instead

Merge branch 'master' into dp/chore/kvdb-no-default-column

* master:
  tx-q: enable basic verification of local transactions (#11332)
  remove null signatures (#11335)
  ethcore/res: activate agharta on classic 9573000 (#11331)
  [secretstore] migrate to version 4 (#11322)
  Enable EIP-2384 for ice age hard fork (#11281)
  Fix atomicity violation in network-devp2p (#11277)
s3krit pushed a commit that referenced this pull request Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281)
* ethcore/res: activate agharta on classic 9573000 (#11331)
* Istanbul HF in xDai (2019-12-12) (#11299)
* Istanbul HF in POA Core (2019-12-19) (#11298)
* Istanbul HF in POA Sokol (2019-12-05) (#11282)
* Activate ecip-1061 on kotti and mordor (#11338)
* Enable basic verification of local transactions (#11332)
* Disallow EIP-86 style null signatures for transactions outside tests (#11335)
s3krit pushed a commit that referenced this pull request Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281)
* ethcore/res: activate agharta on classic 9573000 (#11331)
* Istanbul HF in xDai (2019-12-12) (#11299)
* Istanbul HF in POA Core (2019-12-19) (#11298)
* Istanbul HF in POA Sokol (2019-12-05) (#11282)
* Activate ecip-1061 on kotti and mordor (#11338)
* Enable basic verification of local transactions (#11332)
* Disallow EIP-86 style null signatures for transactions outside tests (#11335)
* SecretStore database migration to v4 (#11322)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants