This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
sync: remove broken eth_protocol_version method #11473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
ordian
force-pushed
the
ao-fix-eth_protocol_version
branch
from
25e35b1
to
e4cf540
Compare
|
Alternatively, we can delete this method altogether (suggested by @grbIzl), any thoughts @dvdplm @niklasad1 ? |
|
I think it is superfluous and would be in favor of removing it altogether. |
ordian
changed the title
ordian
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this method is currently unused, but could be used in #11472.
ATM, it returns the same version as
if warp_protocol { io.protocol_version(&WARP_SYNC_PROTOCOL_ID, peer) } else { ETH_PROTOCOL_VERSION_63.0 };