This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Implement eth/64 (EIP-2364) and drop support for eth/62 #11472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @vorot93 signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
niklasad1
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
ordian
reviewed
Feb 10, 2020
vorot93
force-pushed
the
eip-2364
branch
2 times, most recently
from
30a6f03
to
2b1c29f
Compare
|
I've switched the tests to |
vorot93
changed the title
dvdplm
reviewed
Feb 10, 2020
|
@vorot93 Other than reviewing the code, what's a good way to test this out? |
ordian
reviewed
Feb 10, 2020
dvdplm
reviewed
Feb 11, 2020
dvdplm
reviewed
Feb 11, 2020
dvdplm
reviewed
Feb 11, 2020
ordian
reviewed
Feb 11, 2020
ordian
reviewed
Feb 13, 2020
vorot93
force-pushed
the
eip-2364
branch
3 times, most recently
from
b6aadbe
to
2d801eb
Compare
ordian
reviewed
Feb 18, 2020
ordian
reviewed
Feb 18, 2020
ordian
reviewed
Feb 18, 2020
ordian
added
A8-looksgood 🦄
|
Rebased and squashed |
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
* master: (27 commits) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524) fix compilation warnings (#11522) [ethcore cleanup]: various unrelated fixes from `#11493` (#11507) Add benchmark for transaction execution (#11509) Add Smart Contract License v1.0 Misc fixes (#11510) [dependencies]: unify `rustc-hex` (#11506) Activate on-chain randomness in POA Sokol (#11505) Grab bag of cleanup (#11504) Implement eth/64 (EIP-2364) and drop support for eth/62 (#11472) [dependencies]: remove `util/macros` (#11501) OpenEthereum bootnodes are added (#11499) [ci benches]: use `all-features` (#11496) [verification]: make test-build compile standalone (#11495) complete null-signatures removal (#11491) Include the seal when populating the header for a new block (#11475) fix compilation warnings (#11492) cargo update -p cmake (#11490) update to published rlp-derive (#11489) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ethereum protocol version 64 (
eth/64) described in EIP-2364 and drops support foreth/62.Note that there is a special case for Rinkeby test network since it uses a Clique consensus and has a non-zero Homestead transition block - an edge case that falls outside parity's spec format. Actually fixing this will require breaking json spec format and thus falls outside the scope of this PR.