Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Missing EIP transitions for dev chain spec #11836

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilbayes
Copy link

I found the missing EIP transitions when testing a contract using the SELFBALANCE instruction. I don't see most of these in the docs, but they are present in the foundation.json chain spec. Most of these are related to the Istanbul hard fork

"eip1344Transition": "0x0",
"eip1706Transition": "0x0",
"eip1884Transition": "0x0",
"eip2028Transition": "0x0",
"wasmActivationTransition": "0x0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove parity-wasm if the goal is to make dev chain same as mainnet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know if that’s a goal, but without the above eips some instructions were def missing

@sorpaas sorpaas added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M2-config 📂 Chain specifications and node configurations. labels Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants