Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix signer token updates #3302

Merged
merged 4 commits into from
Nov 9, 2016
Merged

Fix signer token updates #3302

merged 4 commits into from
Nov 9, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 9, 2016

  • when token is initially set to "initial" set correct state
  • fix broken signer paste dialog
  • fix case where status update promise don't return (signer window hanging)

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Nov 9, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 9, 2016

@ngotchac Please check.

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 9, 2016

@gavofyork
Copy link
Contributor

signer tests failing now. @tomusdrw ?

@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 9, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 9, 2016

Tests passing after retry, PR fix for tests available.

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Nov 9, 2016
@arkpar arkpar merged commit 877cfe9 into master Nov 9, 2016
@arkpar arkpar deleted the jg-token-updates branch November 9, 2016 18:45
arkpar pushed a commit that referenced this pull request Nov 9, 2016
* Manual bump of package.json (recovery)

* Debug

* Simplify status connections
arkpar pushed a commit that referenced this pull request Nov 9, 2016
* Manual bump of package.json (recovery)

* Debug

* Simplify status connections
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants