Add missing 'make' dependency (now required by ring) #3658
Conversation
|
It looks like @rangelife hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
tomusdrw
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 134c46e on trblockone:trblockone/docker-missing-make-dependency into ** on ethcore:master**. |
|
[clabot:check] |
|
It looks like @rangelife hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
|
[clabot:check] |
|
It looks like @rangelife hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
|
@rangelife thanks a bunch for your PR. Could you please sign the CLA today if you want this merged. I might have to close this PR and open one myself if you don't as this needs to be fixed asap. |
|
Hi Konstantin
As I work for a corporation my manager needs to approve the licence, and he
won't be back in the office til tomorrow.
If you do close it yourself I'll still proceed to sign the CLA so I can act
more quickly in future.
Thanks
…On Tue, 29 Nov 2016 at 10:48 Konstantin ***@***.***> wrote:
@rangelife <https://github.com/rangelife> thanks a bunch for your PR.
Could you please sign the CLA today if you want this merged. I might have
to close this PR and open one myself if you don't as this needs to be fixed
asap.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/ethcore/parity/pull/3658#issuecomment-263537822>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADdGoZbBJqsxe0rblH01IpYJW-_XjUAks5rDALlgaJpZM4K99Ec>
.
|
|
Fair enough. Closing this in favour of https://github.com/ethcore/parity/pull/3666 . Really appreciate you flagging this up. In the future, with a signed CLA we will be able to have your contributions properly credited |
|
clabot:check |
|
presuably the clabot won't stand in my way next time...? |
|
[clabot:check] |
|
It looks like @rangelife signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
ah :-) forgot the []s, thanks |
No description provided.