This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
verification: add mainnet BadgeReg ids #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
added
A0-pleasereview 🤓
rphmeier
added
B0-patch
and removed
A8-backport 🕸
jacogr
reviewed
Jan 18, 2017
| @@ -23,7 +23,9 @@ import VerificationStore, { | |||
| } from './store'; | |||
| import { isServerRunning, postToServer } from '../../3rdparty/email-verification'; | |||
|
|
|||
| const EMAIL_VERIFICATION = 7; // id in the `BadgeReg.sol` contract | |||
| // ids in the `BadgeReg.sol` contract | |||
| const TESTNET_EMAIL_VERIFICATION = 7; | |||
There was a problem hiding this comment.
This really is dangerous. It means that we need to do code upgrades when we deploy a new version and re-register. The code should just be able to get the info from the network, not via hard-coded ids.
In addition, if we have to deploy the BadgeReg on e.g. ETC we would need to come back here.
I don't have a much better idea since I'm not 100% familiar with what is available, but there must be other solutions instead of relying on certain order in deployments.
There was a problem hiding this comment.
Will try to work it out using BadgeReg.sol.
jacogr
added
A5-grumble 🔥
derhuerst
added
A3-inprogress ⏳
derhuerst
added
A0-pleasereview 🤓
gavofyork
added
the
P2-asap 🌊
jacogr
added
A8-looksgood 🦄
|
A much cleaner implementation as to the original coded Ids. |
arkpar
pushed a commit
that referenced
this pull request
Jan 19, 2017
* verification: mainnet BadgeReg ids * verification: fetch contracts by name * verification: better wording * typo * reregistered badges
arkpar
added a commit
that referenced
this pull request
Jan 19, 2017
* JsonRPC bump for IPC fix * Fixing etherscan price parsing (#4202) * Fixing etherscan price parsing * Handling all errors * Fixed --base-path on windows (#4193) * Fixed --base-path on windows * Add support for optional args with default text * Fixing minimal transaction queue price (#4204) * Fixing minimal transaction queue price * Fixing tests * verification: add mainnet BadgeReg ids (#4190) * verification: mainnet BadgeReg ids * verification: fetch contracts by name * verification: better wording * typo * reregistered badges * Console now has admin (#4220) Fixes #4210 * Non-secure for DappReg (#4216)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were
ropsten-specific before. Not sure if this is the best place to store them.