This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Console now has admin #4220
Merged
Console now has admin #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A2-insubstantial 👶
jacogr
reviewed
Jan 19, 2017
| @@ -18,6 +18,7 @@ | |||
| // TODO: Fix linting issues | |||
|
|
|||
| if (typeof(window.parity) == 'object') | |||
| window.api = window.parent.secureApi; | |||
There was a problem hiding this comment.
We now do have 2 separate instances in here, one via HTTP & one via WS.
Would make sense to have a follow-on where we converge on the secure only. i.e. The next line and friends should be changed to api.subscribe and the parity.js import can be removed.
|
One small comment that we can address in a seperate ticket. (To not blow this one up before release) |
jacogr
added
the
A6-mustntgrumble 💦
arkpar
pushed a commit
that referenced
this pull request
Jan 19, 2017
arkpar
added a commit
that referenced
this pull request
Jan 19, 2017
* JsonRPC bump for IPC fix * Fixing etherscan price parsing (#4202) * Fixing etherscan price parsing * Handling all errors * Fixed --base-path on windows (#4193) * Fixed --base-path on windows * Add support for optional args with default text * Fixing minimal transaction queue price (#4204) * Fixing minimal transaction queue price * Fixing tests * verification: add mainnet BadgeReg ids (#4190) * verification: mainnet BadgeReg ids * verification: fetch contracts by name * verification: better wording * typo * reregistered badges * Console now has admin (#4220) Fixes #4210 * Non-secure for DappReg (#4216)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4210