Fix signing

[gavofyork]

not sure if this is the right way to fix, but it works for me.

[tomusdrw]

Looks fine.

[ngotchac]

address.toLowerCase() could be memoized

[gavofyork]

premature optimisation? this is a bug-fix PR.

[ngotchac]

Is this really working ? Would at least have typeof password === 'string' ? password : password.password or equivalent because it looks strange.

[gavofyork]

the weirdness of naming an object with password and wallet fields password was already there. if this "looks strange", i suggest that variable be renamed rather than adding superfluous logic here.

however i don't know enough of the design behind this module to be sure if renaming is sensible. for sure the original version was buggy and this works under my current usage.

[ngotchac]

Sure, but the issue is comes from components passing different data types to callback props.
Actually, it's views/Signer/components/SignRequest/signRequest.js and views/Signer/components/TransactionPending/transactionPending.js that have different onConfirm method signature/argument types

[ngotchac]

views/Signer/components/TransactionPendingForm/TransactionPendingFormConfirm/transactionPendingFormConfirm.js is passing an Object the the onConfirm prop, and views/Signer/components/SignRequest/signRequest.js is expecting a string.

[ngotchac]

I think that this should be the fix. @tomusdrw @gavofyork and @jacogr ?

diff --git a/js/src/redux/providers/signerMiddleware.js b/js/src/redux/providers/signerMiddleware.js
index 9e56602..b279459 100644
--- a/js/src/redux/providers/signerMiddleware.js
+++ b/js/src/redux/providers/signerMiddleware.js
@@ -120,7 +120,7 @@ export default class SignerMiddleware {
         });
     }
 
-    handlePromise(this._api.signer.confirmRequest(id, { gas, gasPrice }, password.password));
+    handlePromise(this._api.signer.confirmRequest(id, { gas, gasPrice }, password));
   }
 
   onRejectStart = (store, action) => {
diff --git a/js/src/views/Signer/components/SignRequest/signRequest.js b/js/src/views/Signer/components/SignRequest/signRequest.js
index 4a07453..c767697 100644
--- a/js/src/views/Signer/components/SignRequest/signRequest.js
+++ b/js/src/views/Signer/components/SignRequest/signRequest.js
@@ -152,8 +152,9 @@ export default class SignRequest extends Component {
     );
   }
 
-  onConfirm = password => {
+  onConfirm = (data) => {
     const { id } = this.props;
+    const { password } = data;
 
     this.props.onConfirm({ id, password });
   }