Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Available Dapp selection alignment with Permissions (Portal) #4374

Merged
merged 54 commits into from
Feb 2, 2017
Merged

Available Dapp selection alignment with Permissions (Portal) #4374

merged 54 commits into from
Feb 2, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 31, 2017 •
edited
Loading

  1. Consistency between modals in the Dapps view
  2. Split views/Dapp/Summary into ~/ui/DappCard component (re-use between areas)

parity 2017-01-31 17-42-01

@jacogr
Manage default accounts
fd9a23e
@jacogr
Portal
188e7ec
@jacogr
Portal
4ba5e68
@jacogr
Allow Portal to be used in as both top-level and popover
c454f4d
@jacogr
modal/popover variable naming
99b12b0
@jacogr
Merge branch 'jg-modal-portal' into jg-dapp-default-account
3b4cef9
@jacogr
Move to Portal
e138015
@jacogr
export Portal in ~/ui
7605267
@jacogr
Merge branch 'master' into jg-modal-portal
4d677ad
@jacogr
Merge branch 'jg-modal-portal' into jg-dapp-default-account
6e804df
@jacogr
WIP
5846fb1
@jacogr
Tags handle empty values
9144a5f
@jacogr
Export AccountCard in ~/ui
e2cfd8a
@jacogr
Allow ETH-only & zero display
c532993
@jacogr
Use ui/Balance for balance display
0ad816c
@jacogr
Add tests for Balance & Tags component availability
401db9a
@jacogr
Merge branch 'jg-accountcard-updates' into jg-dapp-default-account
70b8a8b
@jacogr
WIP
a3e8cc0
@jacogr
Default overlay display to block (not flex)
6f573c5
@jacogr
Revert block
8e95196
@jacogr
WIP
9cbdcc6
@jacogr
Add className, optional handlers only
9000e0f
@jacogr
Merge branch 'jg-accountcard-updates' into jg-dapp-default-account
8f5934e 
# Conflicts:
#	js/src/ui/Portal/portal.css
#	js/src/ui/Portal/portal.js
@jacogr
WIP
f614a7f
@jacogr
Merge branch 'master' into jg-dapp-default-account
20058b8
@jacogr
Properly handle optional onKeyDown
4c95e75
@jacogr
Merge branch 'jg-modal-portal' into jg-dapp-default-account
e9b6e6a
@jacogr
Selection updated
b8effe6
@jacogr
Align margins
42badf9
@jacogr
Remove old code
7ee15f3
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 31, 2017
@jacogr jacogr mentioned this pull request Feb 1, 2017
Merged
@ngotchac
Copy link
Contributor

ngotchac commented Feb 2, 2017

Two small UI comments:

  1. You might want to get rid of the very last row bottom margin so that the bottom of the scroll bar is aligned with the bottom of the last items.

  2. There is a color animation for the little ticks, but not for the cards background that is changing. Could be nice.

We might also want to remove the body scroll-bar when the Portal is open. Not sure though

@ngotchac ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 2, 2017
@gavofyork gavofyork merged commit 535ebb1 into master Feb 2, 2017
@gavofyork gavofyork deleted the jg-dapps-available-portal branch February 2, 2017 15:02
jacogr added a commit that referenced this pull request Feb 3, 2017
@jacogr
Available Dapp selection alignment with Permissions (Portal) (#4374)
cb3568b
jacogr added a commit that referenced this pull request Feb 3, 2017
@jacogr
Available Dapp selection alignment with Permissions (Portal) (#4374)
f98c15e
gavofyork pushed a commit that referenced this pull request Feb 4, 2017
@jacogr @gavofyork
[beta] UI updates for 1.5.1 (#4429)
fb817fc 
* s/Delete Contract/Forget Contract/ (#4237)

* Adjust the location of the signer snippet (#4155)

* Additional building-block UI components (#4239)

* Currency WIP

* Expand tests

* Pass className

* Add QrCode

* Export new components in ~/ui

* s/this.props.netSymbol/netSymbol/

* Fix import case

* ui/SectionList component (#4292)

* array chunking utility

* add SectionList component

* Add TODOs to indicate possible future work

* Add missing overlay style (as used in dapps at present)

* Add a Playground for the UI Components (#4301)

* Playground // WIP

* Linting

* Add Examples with code

* CSS Linting

* Linting

* Add Connected Currency Symbol

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* Added `renderSymbol` tests

* PR grumbles

* Add Eth and Btc QRCode examples

* 2015-2017

* Add tests for playground

* Fixing tests

* Split Dapp icon into ui/DappIcon (#4308)

* Add QrCode & Copy to ShapeShift (#4322)

* Extract CopyIcon to ~/ui/Icons

* Add copy & QrCode address

* Default size 4

* Add bitcoin: link

* use protocol links applicable to coin exchanged

* Remove .only

* Display QrCode for accounts, addresses & contracts (#4329)

* Allow Portal to be used as top-level modal (#4338)

* Portal

* Allow Portal to be used in as both top-level and popover

* modal/popover variable naming

* export Portal in ~/ui

* Properly handle optional onKeyDown

* Add simple Playground Example

* Add proper event listener to Portal (#4359)

* Display AccountCard name via IdentityName (#4235)

* Fix signing (#4363)

* Dapp Account Selection & Defaults (#4355)

* Add parity_defaultAccount RPC (with subscription) (#4383)

* Default Account selector in Signer overlay (#4375)

* Typo, fixes #4271 (#4391)

* Fix ParityBar account selection overflows (#4405)

* Available Dapp selection alignment with Permissions (Portal) (#4374)

* registry dapp: make lookup use lower case (#4409)

* Dapps use defaultAccount instead of own selectors (#4386)

* Poll for defaultAccount to update dapp & overlay subscriptions (#4417)

* Poll for defaultAccount (Fixes #4413)

* Fix nextTimeout on catch

* Store timers

* Re-enable default updates on change detection

* Add block & timestamp conditions to Signer (#4411)

* Extension installation overlay (#4423)

* Extension installation overlay

* Pr gumbles

* Spelling

* Update Chrome URL

* Fix for non-included jsonrpc

* Extend Portal component (as per Modal) #4392
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacogr @ngotchac @gavofyork