Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

MULTISITE-22513: Check current template #52

Closed
wants to merge 4 commits into from
Closed

MULTISITE-22513: Check current template #52

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2019

Refering to this ticket for more information: https://webgate.ec.europa.eu/CITnet/jira/browse/MULTISITE-22513

composer.json Outdated
@@ -10,7 +10,7 @@
"composer/installers": "^1.5",
"cweagans/composer-patches": "^1.0",
"drupal-composer/drupal-scaffold": "^2.5",
"drupal/core": "^8.7",
"drupal/core": "^8.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, ^8.7 allows Drupal sites to install any core version equal or greater than that, see here: https://semver.mwl.be/#!?package=drupal%2Fcore&version=%5E8.7&minimum-stability=stable

When you'll create a new project by running:

composer create-project openeuropa/drupal-site-template --stability=dev <dg-name>-<project-id>-reference

This will download the latest core version and set it in the lock, which is then committed onto the new project repo.

I've ran a test locally and we should also remove the symfony browser kit dep, since that one will prevent core to be upgraded to 8.8.

Also we should use the occasion to update theme and profile.

All in all this would be the final list of dependencies:

    "require": {
        "php": "^7.1",
        "composer/installers": "^1.5",
        "cweagans/composer-patches": "^1.0",
        "drupal-composer/drupal-scaffold": "^2.5",
        "drupal/core": "^8.7",
        "drush/drush": "^9.0",
        "openeuropa/composer-artifacts": "~0.1",
        "openeuropa/oe_profile": "^0.4",
        "openeuropa/oe_theme": "^2.0",
        "webflo/drupal-finder": "^1.0",
        "webmozart/path-util": "^2.3"
    },
    "require-dev": {
        "drupal/console": "~1.6",
        "drupal/drupal-extension": "~4.0",
        "ec-europa/toolkit": "~4.0.0-beta7",
        "webflo/drupal-core-require-dev": "^8.7"
    },
    "scripts": {
        "post-install-cmd": [
            "DrupalComposer\\DrupalScaffold\\Plugin::scaffold"
        ]
    },

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ademarco , I've applied your changes. And I also tested the behat tests because the composer.json had a comment that said: We explicitly require symfony/browser-kit: ~4.0 otherwise composer update will downgrade to ~3.0 breaking our Behat tests.. The behat tests seem to run just fine on my local.

@ghost
Copy link
Author

ghost commented Jan 7, 2020

Closing this pull request in favor for: #53

@ghost ghost closed this Jan 7, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant