Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-758: Create paragraph 'Timeline' component #124

Merged
merged 33 commits into from
Dec 3, 2021
Merged

OEL-758: Create paragraph 'Timeline' component #124

merged 33 commits into from
Dec 3, 2021

Conversation

Maxfire
Copy link
Contributor

@Maxfire Maxfire commented Nov 23, 2021

escuriola
escuriola suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@escuriola escuriola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing the pattern tests

includes/paragraphs.inc Outdated Show resolved Hide resolved
@Maxfire Maxfire changed the title Oel 758 Oel 758: [BCL upgrade][paragraphs] - Timeline Nov 23, 2021
drishu
drishu requested changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the PR title and description, this will go into the release notes, think of writing something that would make sense in identifying what was done in this PR for anyone that did not participate in the development but wants to use it.

templates/patterns/timeline/timeline.ui_patterns.yml Outdated Show resolved Hide resolved
templates/patterns/timeline/timeline.ui_patterns.yml Outdated Show resolved Hide resolved
includes/paragraphs.inc Outdated Show resolved Hide resolved
includes/paragraphs.inc Outdated Show resolved Hide resolved
templates/paragraphs/paragraph--oe-timeline--default.html.twig Outdated Show resolved Hide resolved
includes/paragraphs.inc Outdated Show resolved Hide resolved
tests/src/Kernel/Paragraphs/TimelineParagraphTest.php Show resolved Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/timeline.yml Outdated Show resolved Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/timeline.yml Outdated Show resolved Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/timeline.yml Show resolved Hide resolved
@Maxfire Maxfire changed the title Oel 758: [BCL upgrade][paragraphs] - Timeline Oel 758: Create paragraph timeline component Nov 26, 2021
@Maxfire Maxfire changed the title Oel 758: Create paragraph timeline component Oel 758: Create paragraph 'Timeline' component Nov 26, 2021
@Maxfire Maxfire changed the title Oel 758: Create paragraph 'Timeline' component OEL-758: Create paragraph 'Timeline' component Nov 29, 2021
drishu
drishu requested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

composer.json Outdated Show resolved Hide resolved
@Maxfire
OEL-758: Timeline paragraph behaviour implemented, tests pending.
a333cfc
@Maxfire
OEL-758: Tests and minor issues added.
87772a4
@Maxfire
OEL-758: Json changes undone.
fc30255
@Maxfire
OEL-758: Pattern test added.
09dd323
@Maxfire
OEL-758: Code clean.
c86b320
@Maxfire
OEL-758: OE content added into composer.json
047e617
@Maxfire
OEL-758: Composer and grump issues solved.
8f515a1
@Maxfire
OEL-758: Feedback applied and oe_content removed from enabling.
6f2956a
@Maxfire
OEL-758: BCL theme version updated.
a774366
@Maxfire
OEL-758: More casuistics added into the tests.
8349f30
@Maxfire
OEL-758: Some changes on feedback applied.
f556871
@Maxfire
OEL-758: Kernel test updated.
db0a593
@Maxfire
OEL-758: Feedback applied.
be67651
@Maxfire
OEL-758: Undoing change bcl builder version.
43934bc
@Maxfire
OEL-758: Markup tests improved.
4949250
@Maxfire
OEL-758: Only added into the pattern.
4729146
@Maxfire
OEL-758: Feedback applied.
201cd82
@Maxfire
OEL-758: Tests adapted to hide_to 0 items.
55bc75d
@drishu drishu merged commit be7e045 into 1.x Dec 3, 2021
@drishu drishu deleted the OEL-758 branch December 3, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escuriola escuriola escuriola approved these changes

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Maxfire @escuriola @drishu