OEL-753: Integrate inpage navigation #137

abel-santos-corral · 2021-12-07T10:52:53Z

Jira issue(s):

OEL-753

(!) Don't merge until OEL-824 is merged at 1.x.

kits/default/package.json

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

package.json

resources/js/libraries/extend/inpage_navigation.js

templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

drishu

Please also check drone before you send this to review!

resources/js/libraries/extend/inpage_navigation.js

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig

tests/src/Kernel/Paragraphs/ContentRowInpageNavigationTest.php

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

resources/js/libraries/extend/inpage_navigation.js

templates/paragraphs/paragraph--oe-content-row--variant-inpage-navigation.html.twig

templates/patterns/inpage_navigation/inpage_navigation.ui_patterns.yml

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

drishu · 2022-01-04T09:48:45Z

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

+      $links_label = $sub_paragraph->get('field_oe_text')->first()->value;
+    }
+    elseif ($sub_paragraph->hasField('field_oe_plain_text_long') && !$sub_paragraph->get('field_oe_plain_text_long')->isEmpty()) {
+      $links_label = $sub_paragraph->get('field_oe_plain_text_long')->first()->value;


Normally you should check first since you wrote the code, I did and indeed it can be way to long, this is a bad idea, we should use just field_oe_title

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module

templates/paragraphs/paragraph--oe-content-row--variant-inpage-navigation.html.twig

oe_bootstrap_theme.libraries.yml

templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig

tests/src/Kernel/Paragraphs/ContentRowInpageNavigationTest.php

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml

…dd tiwg for title of oe_rich_text.

…vigation.

… the paragraph.

…nent.

…bootstrap_theme_paragraphs.module.

… navigation.

…npageNavigationTest.

…t of types at testing.

…ersions fix it.

…ation management.

…ent.

escuriola · 2022-01-07T09:35:59Z

templates/patterns/inpage_navigation/inpage_navigation.ui_patterns.yml

@@ -0,0 +1,27 @@
+inpage_navigation:
+  label: "Inpage navigation"


Use single quotes for this and below

escuriola · 2022-01-07T09:36:40Z

templates/patterns/inpage_navigation/inpage_navigation.ui_patterns.yml

+      type: "render"
+      label: "Content"
+      description: "Content part of the inpage navigation."
+      preview: "<h2 id='item-1'>Heading 1</h2><p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec ut imperdiet neque, finibus pretium metus. Mauris sed consequat purus, eget facilisis arcu. Vestibulum accumsan turpis sed dui placerat, in varius turpis consequat. Pellentesque porta id lorem sit amet efficitur. Sed id ipsum quis metus venenatis facilisis sit amet at mi.</p><h2 id='item-2'>Heading 2 with a long title going on several lines</h2><p>Ut placerat tellus dui, ut tempor orci pulvinar eget. Maecenas hendrerit risus vel tempus tincidunt. Suspendisse vitae ante nibh. Ut faucibus porttitor dui, sit amet pharetra nulla aliquam non. Donec massa mauris, convallis quis nunc nec, ultrices dapibus urna. In vel elementum ipsum, luctus volutpat odio. Maecenas aliquet justo in purus placerat dictum.</p><h2 id='item-3'>Heading 3</h2><p>Curabitur vehicula accumsan placerat. Aliquam eget tincidunt ex, sed elementum justo. Sed faucibus ultrices finibus. Vivamus pellentesque nisl ac interdum ultrices. Quisque ornare sit amet est sed pretium. Aliquam eu leo vitae nisi egestas volutpat ut non lectus. Sed condimentum tempus semper.</p><h2 id='item-4'>Heading 4</h2><p>Nullam dignissim quam tellus, eget pretium tortor vulputate quis. In vehicula enim vitae lorem fermentum convallis. Phasellus bibendum, turpis sit amet faucibus interdum, dui lorem iaculis enim, ac eleifend odio tellus eget dolor. Maecenas nunc ante, tincidunt nec risus ut, eleifend tempor nisi.</p>"


Single quotes please.

escuriola · 2022-01-07T09:37:27Z

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml

+    '#type': pattern
+    '#id': inpage_navigation
+    '#fields':
+      title: "Page content"


Single quotes

escuriola · 2022-01-07T10:57:07Z

templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig

+  'title': title,
+  'links': links,
+  'content': content,
+  'id': 'bcl-inpage-navigation',


Is not needed because component hardcoded the id

escuriola · 2022-01-07T10:59:32Z

templates/patterns/inpage_navigation/inpage_navigation.ui_patterns.yml

+  description: 'Inpage navigation adds a navigation element and content element so when scrolling the active element is indicated in the nav part.'
+  fields:
+    title:
+      type: 'text'


In 799 I'm leaving types without quotes because of reading on IDE, the type has a different color and improve my reading. This is a convention from myself and can be discussed if you want.

Discussed with Francesco, he is agree doing in this way.

abel-santos-corral force-pushed the OEL-753 branch from f3a692a to e340ecf Compare December 7, 2021 11:57

escuriola suggested changes Dec 8, 2021

View reviewed changes

abel-santos-corral force-pushed the OEL-753 branch 2 times, most recently from 4cff2b6 to b1d2eaf Compare December 11, 2021 19:18

escuriola suggested changes Dec 17, 2021

View reviewed changes

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module Outdated Show resolved Hide resolved

modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module Outdated Show resolved Hide resolved

abel-santos-corral force-pushed the OEL-753 branch 2 times, most recently from 06d993f to 0a9ba71 Compare December 19, 2021 18:17

escuriola previously approved these changes Dec 20, 2021

View reviewed changes

drishu requested changes Dec 21, 2021

View reviewed changes

abel-santos-corral dismissed escuriola’s stale review via e1eaf31 January 3, 2022 07:50

drishu changed the title ~~OEL-753: [BCL patterns][Paragraphs] - Inpage navigation~~ OEL-753: Integrate inpage navigation Jan 4, 2022

drishu requested changes Jan 4, 2022

View reviewed changes

drishu requested changes Jan 5, 2022

View reviewed changes

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml Outdated Show resolved Hide resolved

tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml Outdated Show resolved Hide resolved

abel-santos-corral force-pushed the OEL-753 branch 2 times, most recently from 16c9be3 to 840b382 Compare January 6, 2022 12:40

drishu previously approved these changes Jan 7, 2022

View reviewed changes

Maxfire and others added 13 commits January 7, 2022 10:24

OEL-758: Json changes undone.

da72a73

OEL-758: BCL theme version updated.

d8f3f17

OEL-758: Undoing change bcl builder version.

05e343f

OEL-753: Add first release of pattern and twig.

5dc90ab

OEL-753: Add pattern in twig pattern-inpage-navigation.html.twig.

1bf288f

OEL-753: Add management for scrollspy id.

ed6d874

OEL-753: Change label of dropdown identifier.

986ebea

OEL-753: Add kernel tests for inpage navigation.

9986607

OEL-753: Add inpage_navigation javascript.

dba3182

OEL-753: Add paragraph management of inpage variant at content row. A…

0936000

…dd tiwg for title of oe_rich_text.

OEL-753: Add management for accordion paragraph being added to the na…

72a80aa

…vigation.

OEL-753: Add kernel test for inpage navigation paragraph.

7ff59d0

OEL-753: Eliminate superfluous code.

7bf51e4

abel-santos-corral added 20 commits January 7, 2022 10:24

OEL-753: Eliminate the full_layout setting and module and place it on…

5923f6f

… the paragraph.

OEL-753: Add a todo on the oe_bootstrap_theme_paragraphs.module compo…

dc03e32

…nent.

OEL-753: Add default as static string when calling view method on oe_…

9c6034f

…bootstrap_theme_paragraphs.module.

OEL-753: Eliminate default value at paragraph inpage navigation twig.

c7f919b

OEL-753: Eliminate full_layout, is from version greater than 0.14.0.

d719862

OEL-753: Set the pattern example texts as short as possible at Inpage…

eeb9b2c

… navigation.

OEL-753: Remove attributes from pattern Inpage navigation.

4d95a31

OEL-753: Lower the number of paragraphs Rich text at test ContentRowI…

53dc6c5

…npageNavigationTest.

OEL-753: Fix problem at test of pattern of inpage_navigation.

43a9a41

OEL-753: Remove full_layout at pattern inpage_navigation.

0233366

OEL-753: Remove useless comment at testing file.

97abcb6

OEL-753: Eliminate the redundant Rich text paragraphs and add the res…

3fd1adf

…t of types at testing.

OEL-753: Set the scrollspy_id directly in the pattern until further v…

155a48a

…ersions fix it.

OEL-753: Rearrange the module to have it more polite for inpage navig…

5ea812c

…ation management.

OEL-753: Rewrite the test and do a fix in the id of the scrollspy.

c132e44

OEL-753: Rename the library to remove drupal part of the name.

d8f3a81

OEL-753: Eliminate the unset and pass the field_oe_paragraphs to cont…

c7954a2

…ent.

OEL-753: Clarify structure of test Inpage navigation.

de78844

OEL-753: Shorten text at inpage_navigation.yml.

482f5e1

OEL-753: Rearrange inpage navigation's assertions.

a88dc53

abel-santos-corral dismissed drishu’s stale review via a88dc53 January 7, 2022 09:25

abel-santos-corral force-pushed the OEL-753 branch from 840b382 to a88dc53 Compare January 7, 2022 09:25

escuriola suggested changes Jan 7, 2022

View reviewed changes

OEL-753: Use single quote at inpage_navigation files.

ddef1ec

escuriola suggested changes Jan 7, 2022

View reviewed changes

OEL-753: Eliminate quoting at type field. Eliminate id at pattern.

ffa1f40

escuriola approved these changes Jan 7, 2022

View reviewed changes

drishu approved these changes Jan 7, 2022

View reviewed changes

drishu merged commit 1b75d4a into 1.x Jan 7, 2022

drishu deleted the OEL-753 branch January 7, 2022 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OEL-753: Integrate inpage navigation #137

OEL-753: Integrate inpage navigation #137

abel-santos-corral commented Dec 7, 2021 •

edited

Loading

drishu left a comment

drishu Jan 4, 2022

escuriola Jan 7, 2022

escuriola Jan 7, 2022

escuriola Jan 7, 2022

escuriola Jan 7, 2022

escuriola Jan 7, 2022

escuriola Jan 7, 2022

		@@ -0,0 +1,27 @@
		inpage_navigation:
		label: "Inpage navigation"

OEL-753: Integrate inpage navigation #137

OEL-753: Integrate inpage navigation #137

Conversation

abel-santos-corral commented Dec 7, 2021 • edited Loading

drishu left a comment

Choose a reason for hiding this comment

drishu Jan 4, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

escuriola Jan 7, 2022

Choose a reason for hiding this comment

abel-santos-corral commented Dec 7, 2021 •

edited

Loading