OEL-2787: Fix url options loss in bclCardList(). #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGilMartinez
requested changes
Mar 4, 2024
| @@ -381,4 +382,143 @@ protected function elementChildrenFilterDataProvider(): array { | |||
| return $scenarios; | |||
| } | |||
|
|
|||
| /** | |||
| * Tests BCL card list. | |||
There was a problem hiding this comment.
It could be seen like we are going to test card list, I would use the same description than other filter tests.
intelektron
previously approved these changes
Mar 5, 2024
| } | ||
|
|
||
| /** | ||
| * Provides dara for testBclCardList(). |
drishu
force-pushed
the
contribution/OEL-2787
branch
2 times, most recently
from
d7302cc
to
2a2b0a7
Compare
AaronGilMartinez
approved these changes
Mar 11, 2024
intelektron
reviewed
Mar 12, 2024
modules/oe_bootstrap_theme_helper/tests/src/Kernel/TwigExtensionTest.php
Show resolved
Hide resolved
intelektron
approved these changes
Mar 14, 2024
drishu
force-pushed
the
contribution/OEL-2787
branch
from
2a2b0a7
to
43f9837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):