-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-2787: Fix url options loss in bclCardList(). #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little remark, the branch needs to be updated
@@ -381,4 +382,143 @@ protected function elementChildrenFilterDataProvider(): array { | |||
return $scenarios; | |||
} | |||
|
|||
/** | |||
* Tests BCL card list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be seen like we are going to test card list, I would use the same description than other filter tests.
} | ||
|
||
/** | ||
* Provides dara for testBclCardList(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in data
d7302cc
to
2a2b0a7
Compare
modules/oe_bootstrap_theme_helper/tests/src/Kernel/TwigExtensionTest.php
Show resolved
Hide resolved
2a2b0a7
to
43f9837
Compare
Jira issue(s):