Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRONT-2475: Dropdown pattern. #50

Merged
merged 5 commits into from
Sep 29, 2021
Merged

FRONT-2475: Dropdown pattern. #50

merged 5 commits into from
Sep 29, 2021

Conversation

escuriola
Copy link
Contributor

No description provided.

@abel-santos-corral abel-santos-corral linked an issue Aug 25, 2021 that may be closed by this pull request
Refactor Dropdown pattern with BCL component #20
Closed
@abel-santos-corral abel-santos-corral mentioned this pull request Sep 24, 2021
Merged
drishu
drishu requested changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing (see below) and rebase pls.
also look into templates/overrides/navigation/links--dropbutton.html.twig, maybe we need to adapt ? I'm not imposing though, up to you.

templates/patterns/dropdown/pattern-dropdown.html.twig Outdated
{#
/**
* @file
* Dropdown component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Dropdown component.
* Dropdown pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to adapt but I think is not possible. Main reasons:

  • The button for instance sometimes is outlined but at dropdown we cannot set this variant,
  • Links are rendered link objects, so is not possible to pass as variable

@escuriola escuriola merged commit b9abda3 into 1.x Sep 29, 2021
@escuriola escuriola deleted the FRONT-2475 branch September 29, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drishu drishu drishu approved these changes

@abel-santos-corral abel-santos-corral abel-santos-corral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Dropdown pattern with BCL component
3 participants
@escuriola @drishu @abel-santos-corral