Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Dropdown pattern with BCL component #20

Closed
papegaill opened this issue Jul 13, 2021 · 2 comments · Fixed by #50
Closed

Refactor Dropdown pattern with BCL component #20

papegaill opened this issue Jul 13, 2021 · 2 comments · Fixed by #50

Comments

@papegaill
Copy link
Contributor

No description provided.

@abel-santos-corral
Copy link
Contributor

Handled at: https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-412

@abel-santos-corral abel-santos-corral linked a pull request Aug 25, 2021 that will close this issue
FRONT-2475: Dropdown pattern. #50
Merged
@cmarcmar
Copy link

The problem is that in the patterns.inc it tries to access $variables['items'] instead of the new name $variables['dropdown_items'].

Furthermore, an isset check was missing when trying to access and manipulate the variable $item['#url'] causing an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FRONT-2475: Dropdown pattern. openeuropa/oe_bootstrap_theme
3 participants
@papegaill @cmarcmar @abel-santos-corral