FRONT-2479: Modal pattern. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-santos-corral
force-pushed
the
FRONT-2479
branch
2 times, most recently
from
d214b1e
to
dd39863
Compare
drishu
requested changes
Sep 22, 2021
| xl: "xl" | ||
| fullscreen: "fullscreen" | ||
| preview: lg | ||
| id: |
There was a problem hiding this comment.
id is a reserver work for the pattern, if I set this it breaks, use modal_id or something like that
escuriola
force-pushed
the
FRONT-2479
branch
from
dd39863
to
b8de573
Compare
drishu
approved these changes
Sep 23, 2021
abel-santos-corral
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.