Fix: change node express max request body size to 50MB

[haozibi]

The node Express default payload is very small, only about 100kb. When the request payload is large, it will report "Payload Too Large". so the payload size is limited to 50MB.

I feel that HTTP mode also needs to provide several configuration items according to the framework.

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[rimiti]

It's not a good practice to accept big payload. You should avoid that.
Anyway, I not sure about merging this PR. It depends on your use case.

[haozibi]

It's not a good practice to accept big payload. You should avoid that.
Anyway, I not sure about merging this PR. It depends on your use case.

Hello, @rimiti express default bodyParser size is too small (default 100kb), set 50MB just to avoid this problem, you can add configuration items to configure later

Many people have encountered this problem.

• https://stackoverflow.com/questions/19917401/error-request-entity-too-large
• PayloadTooLargeError: request entity too large when trying to POST to apostrophe-headless API apostrophecms/apostrophe#1291 (comment)

[alexellis]

Hi both @haozibi @rimiti

Every PR to OpenFaaS first needs and issue to propose the change.

This is well documented within the contributing guide.

Please could you raise an issue and outline the problem, the proposed solution and any pros/cons that come with it?

In particular I do not believe that hard-coding a 50MB limit comes without cons. As a rule we prefer to make things configurable when the default doesn't suit every user. FYI configuration is usually done via code or via environment variable.

Alex

[haozibi]

Hi both @haozibi @rimiti

Every PR to OpenFaaS first needs and issue to propose the change.

This is well documented within the contributing guide.

Please could you raise an issue and outline the problem, the proposed solution and any pros/cons that come with it?

In particular I do not believe that hard-coding a 50MB limit comes without cons. As a rule we prefer to make things configurable when the default doesn't suit every user. FYI configuration is usually done via code or via environment variable.

Alex

Ok, I know it

[alexellis]

I would like to see the max body size become configurable.

Let's talk on the new issue that you are going to raise now?

Alex