Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Add ip to create-github-command so browser opens on Linux #177

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

Waterdrips
Copy link
Contributor

Description

The linux use for the new create-github-app command didn't open the
browser and point it to the correct place, it just left the url blank.
This change means the browser opens correctly on Linux.

Signed-off-by: Alistair Hey alistair@heyal.co.uk

How Has This Been Tested?

By building and running, as shown below:

heyal@heyal-xps:~/go/src/github.com/openfaas-incubator/ofc-bootstrap$ go build && ./ofc-bootstrap create-github-app --root-domain ofc.heyal.co.uk --insecure
Name: OFC suspicious montalcini6        Root domain: ofc.heyal.co.uk    Scheme: http
Launching browser: http://127.0.0.1:30010
Starting local HTTP server on port 30010
Please complete the workflow in the browser to create your GitHub App.

Screenshot from 2020-01-12 13-36-39

Checklist:

I have:

  • checked my changes follow the style of the existing code / OpenFaaS repos
  • updated the documentation and/or roadmap in README.md
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

The linux use for the new create-github-app command didn't open the
browser and point it to the correct place, it just left the url blank.
This change means the browser opens correctly on Linux.

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexellis alexellis merged commit 6ea5883 into openfaas:master Jan 12, 2020
@Waterdrips Waterdrips deleted the add-ip-to-github-app-create branch January 12, 2020 14:05
@alexellis
Copy link
Member

Thank you 🙏👍🤓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants