Add memory/CPU requests and limits to deploy command #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows for memory/CPU requests and limits to be passed via deploy and store deploy when no additional YAML file is being used. Tested by supplying requests values and looking at the output of faas-cli describe. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
welteki
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add memory/CPU requests and limits to deploy command
Motivation and Context
How Has This Been Tested?
Tested by supplying requests values and looking at the output of faas-cli describe.
Removing the flags removed the values from the function.
Types of changes