Add logging parameters for oidc-plugin

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
openfaas · Apr 23, 2024 · bd99515 · bd99515
1 parent 4220371
commit bd99515
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/chart/openfaas/README.md b/chart/openfaas/README.md
@@ -600,8 +600,9 @@ yaml) |
 | `oidcAuthPlugin.image` | Container image used for the oidc-auth-plugin | See [values.yaml](./values.yaml) |
 | `oidcAuthPlugin.insecureTLS` | Enable insecure TLS | `false` |
 | `oidcAuthPlugin.replicas` | Replicas of the oidc-auth-plugin | `1` |
+| `oidcAuthPlugin.logs.debug` | Log debug messages | `false` |
+| `oidcAuthPlugin.logs.format` | Set the log format, supports `console` or `json` | `console` |
 | `oidcAuthPlugin.resources` | Resource limits and requests for the oidc-auth-plugin containers | See [values.yaml](./values.yaml) |
-| `oidcAuthPlugin.verbose` | Enable verbose logging | `false` |
 
 ### Event subscriptions
 

diff --git a/chart/openfaas/templates/oidc-plugin-dep.yaml b/chart/openfaas/templates/oidc-plugin-dep.yaml
@@ -89,9 +89,6 @@ spec:
           timeoutSeconds: 5
         args:
         - "-license-file=/var/secrets/license/license"
-        {{- if .Values.oidcAuthPlugin.verbose }}
-        - "-verbose=true"
-        {{- end }}
         env:
         - name: base_host
           value: "{{- .Values.iam.systemIssuer.url}}"
@@ -101,6 +98,10 @@ spec:
           value: "{{- .Values.oidcAuthPlugin.insecureTLS}}"
         - name: issuer_key_path
           value: "/var/secrets/issuer-key/issuer.key"
+        - name: "debug"
+          value: "{{ .Values.oidcAuthPlugin.logs.debug }}"
+        - name: "log_encoding"
+          value: "{{ .Values.oidcAuthPlugin.logs.format }}"
         {{ if .Values.caBundleSecretName }}
         - name: ca_bundle_path
           value: /var/secrets/ca-bundle/ca.crt

diff --git a/chart/openfaas/values.yaml b/chart/openfaas/values.yaml
@@ -296,9 +296,11 @@ dashboard:
 oidcAuthPlugin:
   image: ghcr.io/openfaasltd/openfaas-oidc-plugin:0.7.3
   insecureTLS: false
-  verbose: true # debug setting
   replicas: 1
   securityContext: true
+  logs:
+    debug: false
+    format: "console"
   resources:
     requests:
       memory: "120Mi"