Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instances of "faasnetesd" to "faasnetes" #377

Closed
alexellis opened this issue Mar 2, 2019 · 4 comments · Fixed by #378
Closed

Rename instances of "faasnetesd" to "faasnetes" #377

alexellis opened this issue Mar 2, 2019 · 4 comments · Fixed by #378

Comments

@alexellis
Copy link
Member

Actual vs. Expected Behaviour

We renamed "faasnetesd" to "faasnetes" in most locations but missed a few places in the helm chart.

Possible Solution

Let's update the helm chart and re-test locally before pushing out a new version for consistency.

@tac0turtle
Copy link
Contributor

I can take this one

@alexellis
Copy link
Member Author

alexellis commented Mar 6, 2019

@marbar3778 we now need to update all the docs where we see/have faasnetesd -> faasnetes including this:

https://docs.openfaas.com/deployment/kubernetes/#set-a-custom-imagepullpolicy

Over at the openfaas/docs repo. ASAP please

@alexellis
Copy link
Member Author

Thank you @marbar3778 please can you respond to my message from a month ago?

@tac0turtle
Copy link
Contributor

Sorry, I made the changes and messaged you on slack for the pull requests to be merged, so I thought that solved it. From what I can see, I have updated throughout the repo, was it missed anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants