Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instances of "faasnetesd" to "faasnetes" #377

Closed
alexellis opened this Issue Mar 2, 2019 · 2 comments

Comments

2 participants
@alexellis
Copy link
Member

alexellis commented Mar 2, 2019

Actual vs. Expected Behaviour

We renamed "faasnetesd" to "faasnetes" in most locations but missed a few places in the helm chart.

Possible Solution

Let's update the helm chart and re-test locally before pushing out a new version for consistency.

@marbar3778

This comment has been minimized.

Copy link
Contributor

marbar3778 commented Mar 2, 2019

I can take this one

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Mar 6, 2019

@marbar3778 we now need to update all the docs where we see/have faasnetesd -> faasnetes including this:

https://docs.openfaas.com/deployment/kubernetes/#set-a-custom-imagepullpolicy

Over at the openfaas/docs repo. ASAP please

@burtonr burtonr moved this from Help wanted to Review in Triage March 2019 Mar 9, 2019

@burtonr burtonr moved this from Review to Merge in Triage March 2019 Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.