Use faas-cli ready in e2e tests instead of bash #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The faas-cli is now able determine whether the gateway and a specific function are ready. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The previous version of K8s used for testing was v1.21 and hadn't been updated for a long time. This change makes the e2e tests run with the most recent patch at time of writing. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use faas-cli ready in e2e tests instead of bash
Why is this needed?
Less boilerplate code
Who is this for?
Maintainers/contributors and for using OpenFaaS in full e2e test suites.
How Has This Been Tested?
Tested in a GitLab CI job, and will be tested here in CI.
Refactoring/maintenance.