Add conditions to Functions #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
force-pushed
the
function_conditions
branch
from
2011d46
to
73ca19b
Compare
welteki
reviewed
Apr 29, 2024
In order to show when a secret etc is missing, or when the reconciliation is complete from Function to Deployment/Service conditions are added to the status of the Function. Stalled = unable to fully reconcile Ready = reconciled Healthy = Pod available for a request Also adds functions/status to the RBAC for the operator. Fix description of com.openfaas.profile. Via @welteki, before it was invalid with a slash in the annotation name. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
function_conditions
branch
from
114bc98
to
f1ecc47
Compare
welteki
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conditions to Functions
Why is this needed?
Requested by various customers for use with ArgoCD specifically.
How Has This Been Tested?
Tested with ArgoCD and FluxCD with OpenFaaS for Enterprises, with additional edge-case testing done by @welteki
Types of changes
This version of the CRD adds a Status with additional fields, take a moment to examine them, and see the docs at: https://docs.openfaas.com/openfaas-pro/function-crd/