Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkerd auto injection #647

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Add linkerd auto injection #647

merged 1 commit into from
Jun 18, 2020

Conversation

tlemarchand
Copy link
Contributor

@tlemarchand tlemarchand commented Jun 8, 2020

Description

This PR add annotations in namespaces.yml to enable linkerd auto inject, if linkerd is available. It does not change anything if there is no linkerd in the cluster.

Motivation and Context

  • I have raised an issue to propose this change (596)

How Has This Been Tested?

Tested it in our linkerd-enabled AKS cluster. Linkerd sidecars are auto injected and work as intended.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I'm not sure about the documentation, I can add an explanation if needed ?

@derek derek bot added the new-contributor label Jun 8, 2020
@derek
Copy link

derek bot commented Jun 8, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@alexellis
Copy link
Member

Hi @tlemarchand sadly we cannot accept anonymous sign-offs for PRs. Please use your real email and remove the no-reply GitHub address.

git config user.email "real@email.com"
git commit -s --amend
git push origin master --force

@alexellis
Copy link
Member

I'll give you a couple of days to fix this before closing. Let us know if you need any help using git.

alexellis
alexellis previously approved these changes Jun 15, 2020
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to the sign-off being fixed.

Signed-off-by: Thomas Lemarchand <thomas-gh@lemarchand.io>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge

@alexellis alexellis merged commit b45f2fc into openfaas:master Jun 18, 2020
@alexellis
Copy link
Member

Thanks for signing-off. I've merged the PR which means it will be available in master now.

Could you submit a PR to the openfaas-linkerd2 workshop for this new change and test that it works as expected?

https://github.com/openfaas-incubator/openfaas-linkerd2

@tlemarchand
Copy link
Contributor Author

Thanks for merging.

I'll test and write a PR for the workshop, it will be mostly lines removed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants