-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkerd auto injection #647
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Hi @tlemarchand sadly we cannot accept anonymous sign-offs for PRs. Please use your real email and remove the no-reply GitHub address.
|
I'll give you a couple of days to fix this before closing. Let us know if you need any help using git. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to the sign-off being fixed.
Signed-off-by: Thomas Lemarchand <thomas-gh@lemarchand.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for merge
Thanks for signing-off. I've merged the PR which means it will be available in master now. Could you submit a PR to the openfaas-linkerd2 workshop for this new change and test that it works as expected? |
Thanks for merging. I'll test and write a PR for the workshop, it will be mostly lines removed ;) |
Description
This PR add annotations in namespaces.yml to enable linkerd auto inject, if linkerd is available. It does not change anything if there is no linkerd in the cluster.
Motivation and Context
How Has This Been Tested?
Tested it in our linkerd-enabled AKS cluster. Linkerd sidecars are auto injected and work as intended.
Types of changes
Checklist:
git commit -s
I'm not sure about the documentation, I can add an explanation if needed ?