Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress operator CRD to the latest version #656

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

aleks-fofanov
Copy link
Contributor

Signed-off-by: Aleksandr Fofanov avl.fofanov@gmail.com

Description

Update Ingress Operator CRD to the latest version.

Motivation and Context

  • I have raised an issue to propose this change (required)

openfaas/ingress-operator#32

How Has This Been Tested?

minikube start
kubectl create ns openfaas
kubectl create ns openfaas-fn
helm upgrade -i openfaas \
--namespace openfaas \
--set functionNamespace=openfaas-fn \
--set basic_auth=false \
--set generateBasicAuth=false \
--set ingressOperator.create=true \
./chart/openfaas
kubectl get crds functioningresses.openfaas.com -o yaml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Aleksandr Fofanov <avl.fofanov@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexellis alexellis merged commit 52a06b6 into openfaas:master Jun 18, 2020
@alexellis
Copy link
Member

Merged. Thank you. Please feel free to email me an address to alex@openfaas.com if you'd like us to send you some swag to say thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants