Chart fix for profiles_namespace (#675)

[developer-guy]

Description

I moved down "profiles_namespace" env variable to right after line 215 in gateway-dep.yaml within the OpenFaaS templates.

Motivation and Context

I got an error while installing OpenFaas latest version via Helm Chart and then I asked a question about this situation and @LucasRoesler said this is a bug then I opened this PR to fix that bug.

• I have raised an issue to propose this change (required)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[alexellis]

Hi, thank you for the fix, but please can you fill out the PR template? (it applies to everyone, for every PR) thank you 🙏

[developer-guy]

@alexellis, I filled out the PR template 👍

[alexellis]

Message from Lucas on Slack thread "Did I get it right" Lucas: 👍

I'll take that as a LGTM

[LucasRoesler]

yes, and just to be 100% sure, here are the testing steps

$ hub pr checkout 676
$ kind create cluster
$ kubectl create namespace openfaas
$ kubectl create namespace openfaas-fn
$ helm upgrade --install openfaas ./openfaas --namespace openfaas --values ./openfaas/values.yaml --set basic_auth=false
$ kubectl -n openfaas describe deploy gateway
#...
Pod Template:
  Labels:           app=gateway
  Annotations:      prometheus.io.port: 8082
                    prometheus.io.scrape: true
  Service Account:  openfaas-controller
  Containers:
   gateway:
    Image:      openfaas/gateway:0.18.18
    Port:       8080/TCP
    Host Port:  0/TCP
    Requests:
      cpu:      50m
      memory:   120Mi
    Liveness:   http-get http://:8080/healthz delay=0s timeout=5s period=10s #success=1 #failure=3
    Readiness:  http-get http://:8080/healthz delay=0s timeout=5s period=10s #success=1 #failure=3
    Environment:
      read_timeout:             65s
      write_timeout:            65s
      upstream_timeout:         60s
      functions_provider_url:   http://127.0.0.1:8081/
      direct_functions:         true
      direct_functions_suffix:  openfaas-fn.svc.cluster.local
      function_namespace:       openfaas-fn
      faas_nats_address:        nats.openfaas.svc.cluster.local
      faas_nats_port:           4222
      faas_nats_channel:        faas-request
      scale_from_zero:          true
      max_idle_conns:           1024
      max_idle_conns_per_host:  1024
    Mounts:                     <none>
   faas-netes:
    Image:      openfaas/faas-netes:0.12.2
    Port:       8081/TCP
    Host Port:  0/TCP
    Requests:
      cpu:     50m
      memory:  120Mi
    Environment:
      port:                                   8081
      function_namespace:                     openfaas-fn
      profiles_namespace:                     openfaas
      read_timeout:                           60s
      write_timeout:                          60s
      image_pull_policy:                      Always
      http_probe:                             true
      set_nonroot_user:                       false
      readiness_probe_initial_delay_seconds:  2
      readiness_probe_timeout_seconds:        1
      readiness_probe_period_seconds:         2
      liveness_probe_initial_delay_seconds:   2
      liveness_probe_timeout_seconds:         1
      liveness_probe_period_seconds:          2
    Mounts:
      /tmp from faas-netes-temp-volume (rw)
#...

and then you can see the controller startup correctly

$ kubectl -n openfaas logs deploy/gateway faas-netes
2020/08/04 13:45:12 Version: 0.12.2	commit: 6dc57e9230786622ab7cb4fdb4e5621b8e2aad1d
W0804 13:45:12.635235       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
2020/08/04 13:45:12 HTTP Read Timeout: 1m0s
2020/08/04 13:45:12 HTTP Write Timeout: 1m0s
2020/08/04 13:45:12 ImagePullPolicy: Always
2020/08/04 13:45:12 DefaultFunctionNamespace: openfaas-fn
2020/08/04 13:45:12 Starting controller
2020/08/04 13:45:12 Waiting for openfaas CRD cache sync
2020/08/04 13:45:12 Cache sync complete