Support function resolution in multiple namespaces #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
because the namespace is already set when constructing the lister.
The existing code would always return a 404 because it sent the
"function_name.namespace" as the function name. This can never be
found since it is not a valid service name
easier to read. It will now be easier to see which part is the error from the
k8s api.
Motivation and Context
Resolves openfaas/faas#1565
How Has This Been Tested?
The unit test for the proxy resolver has been updated to catch this case and it now passes.
It has also been tested locally using
open http://localhost:8080 and use the UI to deploy and invoke the function
Types of changes
Checklist:
git commit -s