Update CRD specs to use apiextensions v1 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Nov 14, 2020
chart/openfaas/README.md
Outdated
| @@ -377,6 +377,11 @@ It is recommended that you install OpenFaaS to ARM machines [using k3sup](https: | |||
|
|
|||
| See also: [Kubernetes and Raspberry Pi in the docs](https://docs.openfaas.com/deployment/kubernetes) | |||
|
|
|||
| ## Kubernetes versioning | |||
| This Helm chart currently supports version 1.17+ | |||
There was a problem hiding this comment.
Is 1.17 the absolute minimum version for v1?
There was a problem hiding this comment.
I may have read the changlong incorrectly, but see #709 (comment)
There was a problem hiding this comment.
Although, I suspect that that API group isn't actually following the deprecation guidelines, since the v1 rbac group is documented in 1.15 https://v1-15.docs.kubernetes.io/docs/reference/access-authn-authz/rbac/
I will update this to 1.16+ since that is needed for the CRD update
There was a problem hiding this comment.
Sounds good to me. 1.17 may be too aggressive for some users.
LucasRoesler
force-pushed
the
feature-update-crd-api-groups
branch
from
7957ca8
to
d64c446
Compare
**What**
* Update helm chart RBAC templates to use the `rbac.authorization.k8s.io/v1` group. The beta groups will be removed in k8s 1.20
* Update CRD artifacts using the lastest generator: `./hack/update-crds.sh`
* Update helm chart yaml to use the new CRD specs that live in the `apiextensions.k8s.io/v1` group. The beta groups will be removed in k8s 1.19
* Update Chart readme with a section about service meshes
Test the installation via
```sh
$ kind create cluster
$ helm upgrade openfaas --install chart/openfaas/ \
--namespace openfaas \
--set basic_auth=false \
--set functionNamespace=openfaas-fn
Release "openfaas" does not exist. Installing it now.
NAME: openfaas
LAST DEPLOYED: Sat Nov 14 17:11:59 2020
NAMESPACE: openfaas
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
To verify that openfaas has started, run:
kubectl -n openfaas get deployments -l "release=openfaas, app=openfaas"
$ kubectl api-versions | grep openfaas
openfaas.com/v1
$ kubectl get crds
NAME CREATED AT
profiles.openfaas.com 2020-11-14T16:11:59Z
```
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
LucasRoesler
force-pushed
the
feature-update-crd-api-groups
branch
from
d64c446
to
75a12eb
Compare
alexellis
approved these changes
Nov 15, 2020
| @@ -299,6 +299,13 @@ Some configurations in combination with client-side KeepAlive settings may becau | |||
|
|
|||
| If you require TLS/SSL then please make use of an IngressController. A full guide is provided to [enable TLS for the OpenFaaS Gateway using cert-manager and Let's Encrypt](https://docs.openfaas.com/reference/ssl/kubernetes-with-cert-manager/). | |||
|
|
|||
| ### Service meshes | |||
| @@ -377,6 +385,11 @@ It is recommended that you install OpenFaaS to ARM machines [using k3sup](https: | |||
|
|
|||
| See also: [Kubernetes and Raspberry Pi in the docs](https://docs.openfaas.com/deployment/kubernetes) | |||
|
|
|||
| ## Kubernetes versioning | |||
| This Helm chart currently supports version 1.16+ | |||
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rbac.authorization.k8s.io/v1group. The beta groups will be removed in k8s 1.20./hack/update-crds.shapiextensions.k8s.io/v1group. The beta groups will be removed in k8s 1.19Motivation and Context
Resolves Migrate CRDs to v1 namespace #709
How Has This Been Tested?
Test the installation via
$ kind create cluster $ helm upgrade openfaas --install chart/openfaas/ \ --namespace openfaas \ --set basic_auth=false \ --set functionNamespace=openfaas-fn Release "openfaas" does not exist. Installing it now. NAME: openfaas LAST DEPLOYED: Sat Nov 14 17:11:59 2020 NAMESPACE: openfaas STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: To verify that openfaas has started, run: kubectl -n openfaas get deployments -l "release=openfaas, app=openfaas" $ kubectl api-versions | grep openfaas openfaas.com/v1 $ kubectl get crds NAME CREATED AT profiles.openfaas.com 2020-11-14T16:11:59ZTypes of changes
Checklist:
git commit -s