Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRD for IngressOperator #719

Merged
merged 1 commit into from Nov 29, 2020

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Nov 29, 2020

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Description

Update CRD for IngressOperator

Motivation and Context

Fixes: #718

The CRD doesn't appear to have been synced after merging openfaas/ingress-operator#40

Testing

helm upgrade openfaas --install chart/openfaas \
    --namespace openfaas  \
    --set basic_auth=true \
    --set functionNamespace=openfaas-fn \
    --set ingressOperator=true

The CRD applied and worked followed by:

kubectl -n openfaas logs deployment/ingress-operator
I1129 15:32:24.947893       1 main.go:52] Starting FunctionIngress controller version: 0.6.6 commit: 01e49ccaa4eafe1bb019803cc485decaca3badbc
W1129 15:32:24.948382       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1129 15:32:24.950844       1 controller.go:122] Setting up event handlers
I1129 15:32:24.950954       1 controller.go:183] Waiting for informer caches to sync
I1129 15:32:25.051267       1 controller.go:188] Starting workers
I1129 15:32:25.051326       1 controller.go:194] Started workers

I then applied a FunctionIngress record and got:

NAMESPACE   NAME       CLASS    HOSTS                  ADDRESS      PORTS   AGE
openfaas    nodeinfo   <none>   nodeinfo.myfaas.club   172.18.0.2   80      15s

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Fixes: #718

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit b731fb3 into master Nov 29, 2020
@alexellis alexellis deleted the openfaasltd/upgrade-ingress-operator-crd branch November 29, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not enable IngressOperator through Helm Chart
2 participants