Silence errors for namespace listing #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #724 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
openfaasltd/silence-ns-error
branch
from
411aefa
to
8db91a6
Compare
LucasRoesler
requested changes
Dec 5, 2020
Comment on lines
+30
to
+35
| namespaces := []string{} | ||
| if clusterRole { | ||
| namespaces = ListNamespaces(defaultNamespace, clientset) | ||
| } else { | ||
| namespaces = append(namespaces, defaultNamespace) | ||
| } |
There was a problem hiding this comment.
We could slightly simplify this using
Suggested change
| namespaces := []string{} | |
| if clusterRole { | |
| namespaces = ListNamespaces(defaultNamespace, clientset) | |
| } else { | |
| namespaces = append(namespaces, defaultNamespace) | |
| } | |
| namespaces := []string{defaultNamespace} | |
| if clusterRole { | |
| namespaces = ListNamespaces(defaultNamespace, clientset) | |
| } |
| return func(w http.ResponseWriter, r *http.Request) { | ||
| log.Println("Query namespaces") | ||
| // log.Println("List namespaces") |
There was a problem hiding this comment.
Just delete it
Suggested change
| // log.Println("List namespaces") |
There was a problem hiding this comment.
Agreed. I am still undecided about whether we should delete all happy-path logging and focus on the Prometheus metrics gathered from the gateway.
| @@ -102,6 +103,7 @@ func MakeReplicaReader(defaultNamespace string, clientset *kubernetes.Clientset) | |||
| lookupNamespace = namespace | |||
| } | |||
|
|
|||
| s := time.Now() | |||
There was a problem hiding this comment.
This might be more valuable as an actual prometheus metric. Having it in the logs is nice, but it means a person is going to make judgments on a few values as opposed to being able to collect and aggregate real data into graphs etc.
There was a problem hiding this comment.
I agree. I think it is in there already 👍 This is another example of a log message we should probably delete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #724
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
Silence errors for namespace listing
Motivation and Context
Fixes: #724
How Has This Been Tested?
To be tested through CI
Types of changes