You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But then I realized I wasn't sure what it was for. It is not referenced in the CI flow or the Readme. It looks like it was an early demo prototype for how the faas-provider works. The Readme now references the concrete implementation in faas-netes, perhaps we can remove this Dockerfile?
The text was updated successfully, but these errors were encountered:
LucasRoesler
changed the title
[Question]
[Question] Should we remove the Dockerfile
Jan 26, 2020
* Switch to Go modules
* Remove dep
* `go build` worke
* `go test ./...` worked too
* Remove Dockerfile, Closes: #40
* Update Travis to use Go 1.13
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
* Switch to Go modules
* Remove dep
* `go build` worke
* `go test ./...` worked too
* Remove Dockerfile, Closes: #40
* Update Travis to use Go 1.13
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
I was about to open a PR for the Go modules migration when I realized that this Dockerfile may need to be updated https://github.com/openfaas/faas-provider/blob/master/Dockerfile
But then I realized I wasn't sure what it was for. It is not referenced in the CI flow or the Readme. It looks like it was an early demo prototype for how the
faas-provider
works. The Readme now references the concrete implementation in faas-netes, perhaps we can remove this Dockerfile?The text was updated successfully, but these errors were encountered: