Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NATS Streaming to 0.11.0 #790

Closed
alexellis opened this issue Jul 25, 2018 · 16 comments
Closed

Update NATS Streaming to 0.11.0 #790

alexellis opened this issue Jul 25, 2018 · 16 comments
Assignees
@LucasRoesler
Labels
help wanted size/m skill/intermediate

Comments

@alexellis
Copy link
Member

alexellis commented Jul 25, 2018 •
edited

Suggestion

It looks like nats-streaming has a new version 0.12.0 - we should test this and move to it if it is stable.

Changes

  • docker-compose.yml
  • helm chart
  • Kubernetes YAML files

https://hub.docker.com/_/nats-streaming/

Additional due diligence:

  • check client library and re-vendor/update if needed
  • "handler" package in queue-worker may need to be revendorded, which is a rebuilt of the gateway
  • check queue-worker can still pull work and process it
@alexellis
Copy link
Member Author

Anything else to add @stefanprodan ?

@martindekov
Copy link
Contributor

I can work on this one. Can I assign myself ?

@alexellis
Copy link
Member Author

(This work needs thorough regression/hands-on testing)

@martindekov
Copy link
Contributor

Yeah ok I will continue with the faas-cli.

@burtonr
Copy link
Contributor

burtonr commented Sep 23, 2018

Derek assign: martindekov

@burtonr
Copy link
Contributor

burtonr commented Sep 23, 2018

@martindekov if you are no longer working on this you can use Derek unassign: me in order to remove yourself from the issue.

@martindekov
Copy link
Contributor

Hey @burtonr I just saw you assigned me. I actually meant I am passing that and haven't even started working on it. If you want to work on this take it.

@martindekov
Copy link
Contributor

Derek unassign: me

@derek derek bot unassigned martindekov Sep 25, 2018
@LucasRoesler
Copy link
Member

Derek assign: me

LucasRoesler added a commit to LucasRoesler/faas that referenced this issue Oct 3, 2018
@LucasRoesler
Bump nats-streaming version to 0.11.0
9921769 
**What**
- Bumpe nats-streaming version to 0.11.0 in the docker-compose files
- Addresses openfaas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler
Copy link
Member

I just looked at the nats client library and there are no newer releases than our currently vendored package

@LucasRoesler LucasRoesler mentioned this issue Oct 3, 2018
Merged
11 tasks
LucasRoesler added a commit to LucasRoesler/faas-netes that referenced this issue Oct 3, 2018
@LucasRoesler
Bump nat-streaming to 0.11.0
e82a6a4 
**What**
- Bump the nats-streaming version to 0.11.0 in the docker-compose files, this is the latest tag published on Docker Hub
- Add names to nats ports
- Update nats command to enable the monitoring port
- Addresses openfaas/faas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
LucasRoesler added a commit to LucasRoesler/faas-netes that referenced this issue Oct 3, 2018
@LucasRoesler
Bump nat-streaming to 0.11.0
e65593d 
**What**
- Bump the nats-streaming version to 0.11.0 in the docker-compose files, this is the latest tag published on Docker Hub
- Add names to nats ports
- Update nats command to enable the monitoring port
- Addresses openfaas/faas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler LucasRoesler mentioned this issue Oct 3, 2018
Merged
11 tasks
@LucasRoesler
Copy link
Member

It is also worth noting that the title for this ticket says version 0.12.0 but the latest tag I could find for nats-streaming is 0.11.0

@kozlovic
Copy link

Yes, latest is only 0.11.2.

LucasRoesler added a commit to LucasRoesler/faas-netes that referenced this issue Oct 20, 2018
@LucasRoesler
Bump nat-streaming to 0.11.0
4516bfa 
**What**
- Bump the nats-streaming version to 0.11.0 in the docker-compose files, this is the latest tag published on Docker Hub
- Add names to nats ports
- Update nats command to enable the monitoring port
- Addresses openfaas/faas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
LucasRoesler added a commit to LucasRoesler/faas that referenced this issue Oct 20, 2018
@LucasRoesler
Bump nats-streaming version to 0.11.0
49e2e27 
**What**
- Bumpe nats-streaming version to 0.11.0 in the docker-compose files
- Addresses openfaas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
alexellis pushed a commit that referenced this issue Oct 26, 2018
@LucasRoesler @alexellis
Bump nats-streaming version to 0.11.0
cbf39f0 
**What**
- Bumpe nats-streaming version to 0.11.0 in the docker-compose files
- Addresses #790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@alexellis
Copy link
Member Author

Derek set title: Update NATS Streaming to 0.11.0

@derek derek bot changed the title Update NATS Streaming to 0.12.0 Update NATS Streaming to 0.11.0 Oct 26, 2018
LucasRoesler added a commit to LucasRoesler/faas-netes that referenced this issue Oct 28, 2018
@LucasRoesler
Bump nat-streaming to 0.11.0
0a10d9b 
**What**
- Bump the nats-streaming version to 0.11.0 in the docker-compose files, this is the latest tag published on Docker Hub
- Add names to nats ports
- Update nats command to enable the monitoring port
- Addresses openfaas/faas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
alexellis pushed a commit to openfaas/faas-netes that referenced this issue Oct 28, 2018
@LucasRoesler @alexellis
Bump nat-streaming to 0.11.0
2a085aa 
**What**
- Bump the nats-streaming version to 0.11.0 in the docker-compose files, this is the latest tag published on Docker Hub
- Add names to nats ports
- Update nats command to enable the monitoring port
- Addresses openfaas/faas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@alexellis
Copy link
Member Author

@LucasRoesler where are we with this now?

@LucasRoesler
Copy link
Member

This is closed

@LucasRoesler
Copy link
Member

Derek close

@derek derek bot closed this as completed Jan 7, 2019
kiku-jw pushed a commit to kiku-jw/faas that referenced this issue Mar 7, 2019
@LucasRoesler @kiku-jw
Bump nats-streaming version to 0.11.0
55d5027 
**What**
- Bumpe nats-streaming version to 0.11.0 in the docker-compose files
- Addresses openfaas#790

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasRoesler LucasRoesler

Labels
help wanted size/m skill/intermediate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LucasRoesler @alexellis @burtonr @kozlovic @martindekov