Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export new metrics for OpenFaaS Pro scaling #1691

Merged
merged 1 commit into from Jan 24, 2022

Conversation

alexellis
Copy link
Member

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Description

Export new metrics for OpenFaaS Pro scaling

Motivation and Context

  • Add service target metric
  • Add service min replicas metric
  • Add scale type metric

These combined allow new auto-scaling modes and parameters
for OpenFaaS Pro customers.

How Has This Been Tested?

Tested with a local build of the image from within KinD. The new metrics showed up as expected when inputted via labels via faas-cli deploy.

For example:

faas-cli store deploy cows \
--label com.openfaas.scale.max=5 \
--label com.openfaas.scale.target=50 \
--label com.openfaas.scale.type=cpu \
--label com.openfaas.scale.target-proportion=0.70 \
--label com.openfaas.scale.zero=false

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

No impact to existing users is expected.

Checklist:

  • My change requires a change to the documentation.

Documentation change is to follow on the metrics page.

* Add service target metric
* Add service min replicas metric
* Add scale type metric

These combined allow new auto-scaling modes and parameters
for OpenFaaS Pro customers.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit d85d5e7 into master Jan 24, 2022
@alexellis alexellis deleted the openfaasltd/pro-scaling-metrics branch May 23, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant