Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing namespace field to the scale request #1803

Merged
merged 1 commit into from
Jul 19, 2023
Merged

docs: add missing namespace field to the scale request #1803

merged 1 commit into from
Jul 19, 2023

Conversation

LucasRoesler
Copy link
Member

The ScaleFunction request supports specifying the function namespace. This is now included in the API spec.

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

This issue was discussed during the last Community call

How Has This Been Tested?

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LucasRoesler
docs: add missing namespace field to the scale request
27f0a12 
The ScaleFunction request supports specifying the function namespace.
This is now included in the API spec.

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
alexellis
alexellis approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should also be added to the delete operation in the same way if it's not already.

@alexellis alexellis merged commit 5c851cd into openfaas:master Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucasRoesler @alexellis