Fix bug reading default value for combine_output #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanayov
approved these changes
Mar 22, 2018
The default should be set to true so we maintain backwards. compatibility. readconfig.go was altered due to bug reading default value. This was tested by adding unit tests to readconfig_test.go for positive and negative scenarios. Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
alexellis
force-pushed
the
fix_combine_output_defaults
branch
from
0d528b5
to
e442da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default should be set to true so we maintain backwards.
compatibility. readconfig.go was altered due to bug reading default value.
Signed-off-by: Alex Ellis (VMware) alexellis2@gmail.com
Motivation and Context
Issue spotted by Ivana @iyovcheva
How Has This Been Tested?
This was tested by adding unit tests to readconfig_test.go for positive and
negative scenarios.
Also built a local watchdog and checked default behavior was fixed.
Types of changes
Checklist:
git commit -s