Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Go modules and remove vendor dir #63

Closed
carlosedp opened this issue Mar 8, 2020 · 2 comments
Closed

Migrate to Go modules and remove vendor dir #63

carlosedp opened this issue Mar 8, 2020 · 2 comments

Comments

@carlosedp
Copy link
Contributor

carlosedp commented Mar 8, 2020

Expected Behaviour

Use Go modules instead of dep and remove vendor directory since go modules now handles caching into ~/go/pkg/mod.

The advantage is that it's built-in Go since 1.13 and production on 1.14 ready as stated in https://blog.golang.org/go1.14.

Current Behaviour

Building requires dep, an external application.

Possible Solution

Will submit a PR if the proposal gets +1.

@alexellis
Copy link
Member

Not approved. Please hold off on this.

@alexellis
Copy link
Member

We've gone over to Go modules, but the vendor directory should say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants