-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopping faasd and faasd-provider should stop all containers #64
Comments
Apparently Prometheus is preventing the stop to proceed. I changed : File
And got:
What is weird is that Prometheus stopped thru faasd never prints it's last message like stopping it manually with
|
One issue I believe @alexellis might need to direct is how the provider should behave related to deployed functions. Since faasd-provider does not keep the state, if it is stopped and the functions deleted, when started back the functions would not be recreated. One option would be just stopping the functions (killing it's tasks) but keeping the container so in the event of a restart, faasd-provider would scale it back to 1 on access. What do you think? |
Why do you feel that is this change required? (I may not understand the problem well enough, I'm listening) |
/lock: closed |
Expected Behaviour
Stopping faasd and faasd-provider should stop all containers. When the processes
faasd
andfaasd-provider
are stopped (with sysctl), it's expected that all containers should be stopped.Current Behaviour
Some container tasks remain in
RUNNING
state.Before stop, all tasks are running:
After service stop:
As seen, the deployed function,
figlet
and the containersgateway
andqueue-worker
still had their tasks running.Below the stop logs:
Possible Solution
Steps to Reproduce (for bugs)
sudo ctr -n openfaas-fn task ls
andsudo ctr task ls
.Context
Your Environment
Latest
faasd
built frommaster
.The text was updated successfully, but these errors were encountered: