Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-arch support, with fallback to current behaviour #47

Closed
alexellis opened this issue Sep 6, 2020 · 3 comments
Closed

Add multi-arch support, with fallback to current behaviour #47

alexellis opened this issue Sep 6, 2020 · 3 comments

Comments

@alexellis
Copy link
Member

Task

Add multi-arch support, with fallback to current behaviour

Update the existing Dockerfiles as per: https://github.com/alexellis/multiarch-templates/blob/master/template/go-multiarch/Dockerfile

Testing instructions

Test as per: https://github.com/alexellis/multiarch-templates

And make sure that faas-cli up still works without any multi-arch considerations.
@utsavanand2
Copy link
Contributor

I would love to take a go at this

@alexellis
Copy link
Member Author

Please do. You should just need to copy and paste from the example above.

utsavanand2 added a commit to utsavanand2/golang-http-template that referenced this issue Sep 8, 2020
@utsavanand2
Fixes: openfaas#47 Add multi-arch support for golang-http-template
0d4f64e 
Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
@utsavanand2
Copy link
Contributor

@alexellis PR #48 addresses this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexellis @utsavanand2