Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of-watchdog 0.9.3 to suppress custom health check logging messages #66

Merged

Conversation

nitishkumar71
Copy link
Contributor

Signed-off-by: Nitishkumar Singh nitishkumarsingh71@gmail.com

Description

Use of-watchdog 0.9.3 to suppress custom health check logging messages

Closes #65

How Has This Been Tested?

  1. Made changes into template
  2. Created new function with from local templates using faas-cli new golang-http-test --lang golang-http
  3. Build function faas-cli build -f ./golang-http-test.yml
  4. Deploy function faas-cli deploy -f ./golang-http-test.yml
  5. Invoke function

How are existing users impacted? What migration steps/scripts do we need?

Only custom health check logs are being removed from logs. Ideally it should not impact any user, unless they are monitoring health check logs

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
@alexellis
Copy link
Member

Thank you for the PR.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 5cd3573 into openfaas:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of-watchdog 0.9.3 to suppress custom health check logging messages
2 participants