Fixed bad pointer when function fails #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If function call ends up giving 503,
nats-queue-worker
crashes withpanic: runtime error: invalid memory address or nil pointer dereference
when trying to do callback.Description
If
X-Callback-Url
is set, and the function call gives 503,functionRes
isnil
, but we try to evaluatefunctionRes.Header.Get("X-Duration-Seconds")
in thepostResult
function. This leads to null pointer error and a dying pod. The call is then being retried multiple times on any new queue-worker pod starting.This PR adds the timeout directly to the headers instead.
Motivation and Context
Crashing queue worker in the state mentioned above.
queue-worker crashes if callback happens and function call failed #90
How Has This Been Tested?
I have patched the worker and tried with and without the change and verified that it does not crash with this patch. I tested this with the following images
Types of changes
Checklist:
git commit -s