Update registry_login.go

[edmooney]

/v1/ is throwing 404s

Description

docker /v1/ path is throwing URLs - looks to be no longer supported. Therefore was not able to generate the ./credentials/config.json file for access.

How Has This Been Tested?

unable to test on my current machine

Checklist:

I have:

• checked my changes follow the style of the existing code / OpenFaaS repos
• updated the documentation and/or roadmap in README.md
• read the CONTRIBUTION guide
• signed-off my commits with git commit -s
• added unit tests

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[alexellis]

@Waterdrips please could you take a look?

[edmooney]

@Waterdrips @alexellis - I can build it when I get on my other machine - figured I would log it as FYI, in case someone can get to it.

[Waterdrips]

@edmooney The command doent use those urls as webpages, they are authentication endpoints for the docker login command (in cluster) the docker docks still point to v1 and i was able to generate, then use, the credentials with /v1/

docs: https://docs.docker.com/engine/reference/commandline/login/

What was the error or issue you saw?

[edmooney]

@Waterdrips - This is is on my side - On this machine using Windows WSL - Docker is flaking out. Closing this PR. Apologies.

[Waterdrips]

Ah ok, that --password-stdin requires you to explicitly close the reading from stdin, the library expects a "ctrl+d" on linux to end read, this allows multiline inputs.

[edmooney]

confirmed: it looks like the stdin (ctrl-d). - Not code related- TY!

[alexellis]

Sounds like it may have been due to us reading the password from stdin. For tech support Slack tends to be better for us.

Do let us know if you run into anything else.

[alexellis]

Thanks @Waterdrips