Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Update instructions to use github-event, not github-push #142

Closed
alexellis opened this issue Sep 7, 2018 · 0 comments
Closed

Update instructions to use github-event, not github-push #142

alexellis opened this issue Sep 7, 2018 · 0 comments
Assignees

Comments

@alexellis
Copy link
Member

Expected Behaviour

github-event adds support for removing functions when an installation removed event is received.

It should be what we point at for webhooks rather than to: github-push.

  • Set its name as: system-github-event (don't rename the handler)
  • Set the name of system-github-push to github-push (only in the YAML)

Update the instructions in docs/README.md

Test end-to-end on your own cluster by using the router and the address system.domain.com/github-event.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants