Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

github-push: Add user id support. #313

Closed
martindekov opened this issue Oct 29, 2018 · 4 comments
Closed

github-push: Add user id support. #313

martindekov opened this issue Oct 29, 2018 · 4 comments
Assignees

Comments

@martindekov
Copy link
Contributor

Currently the user is recognized mainly through the username. Which is not unique and can be changed. We should add user ID to the struct and apply it as label through buildshiprun.

Expected Behaviour

Add handling for user ID in PushEvent struct handle it then add it as label through buildshiprun

Current Behaviour

We don't support buildshiprun

Possible Solution

Extend struct in SDK and send to buildshiprun to be applied as label to the function

Steps to Reproduce (for bugs)

This is a feature

Context

User ID is constant and cannot be changed. Username can be changed.

@martindekov
Copy link
Contributor Author

Derek assign: me

@martindekov
Copy link
Contributor Author

This was implemented in git-tar and buildshiprun

@alexellis
Copy link
Member

Thanks for the update and for the git commits 👍 can you confirm that you have the data flowing through to your functions from OpenFaaS Cloud?

@martindekov
Copy link
Contributor Author

Ok no problems

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants